diff --git a/backend/e2e/podcast-guest-form.spec.js b/backend/e2e/podcast-guest-form.spec.js index b559b9f2..9a138bda 100644 --- a/backend/e2e/podcast-guest-form.spec.js +++ b/backend/e2e/podcast-guest-form.spec.js @@ -105,8 +105,8 @@ test.describe("podcast guest materials form", () => { // Episodes release strictly in number order: the first test's S25E9 is // on this same server two weeks out, so S25E8 releases the week before. const episode = await api("/api/podcast-episodes", { - season: 25, - episode: 8, + season: 26, + episode: 1, releaseAssignmentStatus: "provisional", releaseDate: releaseFriday(7), title: "Guest form alias e2e", @@ -121,6 +121,7 @@ test.describe("podcast guest materials form", () => { await page.setViewportSize({ width: 390, height: 844 }); await page.goto(`${server.baseURL}/sponsor-docs/${doc.id}?code=${encodeURIComponent(doc.accessCode)}`); await expect(page.locator('[data-sponsor-view="editor"]')).toBeVisible(); + expect(page.url()).toContain(`/podcast-docs/${doc.id}`); const aliasGuestRegions = page.locator( ".sponsor-doc-meta, .sponsor-doc-form-card, [data-sponsor-export]", ); diff --git a/backend/src/calendar/cardInvite.ts b/backend/src/calendar/cardInvite.ts index 72533877..3cfdb79a 100644 --- a/backend/src/calendar/cardInvite.ts +++ b/backend/src/calendar/cardInvite.ts @@ -22,6 +22,7 @@ import { recordTemplateTypes } from '../cards/cardTitlePattern'; import { deleteHoldGoogleEvents, fetchGoogleEvent, findGoneGoogleEvents, mergeHoldGoogleResults, syncLumaCalendarEvents, syncSilentGoogleCopies, type HoldGoogleDeps, type HoldGoogleResult } from './holdGoogleSync'; import { lumaUrlForEventCard } from './lumaEvents'; import { PUBLIC_DTC_EVENTS_CALENDAR, resolveHoldGoogleCalendars } from './dapierBroker'; +import { decryptSponsorDocAccessCode, getSponsorDocWithAuthMaterial } from '../db/sponsorDocs'; /** AISHL workshops are scheduled by the AISHL site event, which sends its own invite and Zoom. */ const AISHL_TEMPLATE_TYPE = 'aishl-workshop'; @@ -79,6 +80,30 @@ export function cardGuestDocument(card: Card): string | undefined { catch { throw new CardInviteInputError('The Card guest document must be an HTTPS URL.'); } } +/** + * Append `?code=...` to a `/podcast-docs/` URL when the document has a + * decryptable access code so both the guest and Alexey can open it from the + * calendar invite without looking up the code. + */ +export async function resolveGuestDocumentUrlWithCode( + client: DynamoDBDocumentClient, + rawUrl: string | undefined, +): Promise { + if (!rawUrl) return rawUrl; + const match = /^https:\/\/[^/]+\/podcast-docs\/([^/?#]+)\/?$/.exec(rawUrl.trim()); + if (!match) return rawUrl; + const docId = decodeURIComponent(match[1]); + try { + const loaded = await getSponsorDocWithAuthMaterial(client, docId); + if (!loaded) return rawUrl; + const accessCode = decryptSponsorDocAccessCode(docId, loaded.accessCodeCiphertext); + if (!accessCode) return rawUrl; + return `${rawUrl.replace(/\/$/, '')}?code=${encodeURIComponent(accessCode)}`; + } catch { + return rawUrl; + } +} + const EMAIL = /^[^\s@]+@[^\s@]+\.[^\s@]+$/; export function parseCardGuests(raw: unknown): string[] { if (!Array.isArray(raw) || !raw.length || raw.length > 20) throw new Error('guestEmails must contain 1 to 20 guest email addresses'); @@ -298,6 +323,7 @@ export async function syncCardInvite( const cardDocument = cardGuestDocument(card); documentUrl = (cardDocument && DATAOPS_GUEST_DOC.test(cardDocument) ? cardDocument : undefined) || parseHoldDocumentUrl(linkedHold?.documentUrl) || cardDocument; + documentUrl = await resolveGuestDocumentUrlWithCode(client, documentUrl); } catch { throw new CardInviteInputError('The guest document must be an HTTPS URL.'); } invite = { ...buildGuestInvite({ diff --git a/backend/src/cards/recordCardLink.ts b/backend/src/cards/recordCardLink.ts index 0cd42960..d7ef21f9 100644 --- a/backend/src/cards/recordCardLink.ts +++ b/backend/src/cards/recordCardLink.ts @@ -42,8 +42,16 @@ function projected(card: Card, templateIdByType: Map): Card { export async function summarizeCard( client: DynamoDBDocumentClient, card: Card, -): Promise { +): Promise { const view = projected(card, await getTemplateIdByType(client)); + const podcastLink = (card.cardLinks || []).find((l) => /\/podcast-docs\/[^/?#]+/.test(String(l.url || ''))); + let podcastDocUrl = podcastLink?.url ? String(podcastLink.url).trim() : undefined; + if (!podcastDocUrl) { + const { listSponsorDocSummariesByCardId } = await import('../db/sponsorDocs'); + const docs = await listSponsorDocSummariesByCardId(client, card.id); + const podDoc = docs.find((d) => d.template === 'podcast'); + if (podDoc) podcastDocUrl = `/podcast-docs/${encodeURIComponent(podDoc.id)}`; + } return { id: card.id, title: String(view.title || ''), @@ -52,6 +60,7 @@ export async function summarizeCard( anchorDate: view.anchorDate || null, taskCount: card.taskCount, openTaskCount: card.openTaskCount, + ...(podcastDocUrl ? { podcastDocUrl } : {}), }; } diff --git a/backend/src/events/service.ts b/backend/src/events/service.ts index 04fb3a5e..259e9c7d 100644 --- a/backend/src/events/service.ts +++ b/backend/src/events/service.ts @@ -29,6 +29,7 @@ import { cardGuests, closeCardInviteTasks, parseCardGuests, + resolveGuestDocumentUrlWithCode, resolvePodcastCardInviteTitle, } from '../calendar/cardInvite'; import { GuestInviteValidationError, isPodcastTemplateType, type GuestInvite } from '../calendar/guestInvite'; @@ -782,10 +783,11 @@ async function runTransition( (card.people?.length ? card.people.join(', ') : episode?.guests?.map((g) => g.name).join(', ') || current?.renderValues?.guestNames || ''); - const documentUrl = + const rawDocUrl = input.documentUrl !== undefined ? input.documentUrl : current?.renderValues?.documentUrl || cardGuestDocument(card) || ''; + const documentUrl = (await resolveGuestDocumentUrlWithCode(client, rawDocUrl)) || ''; let time = input.time; let proposalDate = input.date || current?.date || card.anchorDate; @@ -857,10 +859,11 @@ async function runTransition( (card.people?.length ? card.people.join(', ') : episode?.guests?.map((g) => g.name).join(', ') || ''); - const documentUrl = + const rawDocUrl = input.documentUrl !== undefined ? input.documentUrl : current.renderValues.documentUrl || cardGuestDocument(card) || ''; + const documentUrl = (await resolveGuestDocumentUrlWithCode(client, rawDocUrl)) || ''; command = { transition: 'update', operationKey, diff --git a/backend/src/router.ts b/backend/src/router.ts index 2e7abde4..af9babe4 100644 --- a/backend/src/router.ts +++ b/backend/src/router.ts @@ -62,7 +62,7 @@ import { handleInvoiceReader } from './auth/invoiceReader'; import { handleKnowledgePublisher } from './auth/knowledgePublisher'; import { isScopedTokenRequestAllowed } from './auth/tokenScopes'; import { getApiToken, projectApiToken } from './db/apiTokens'; -import { handleSponsorDocRoutes, isAnonymousSponsorDocRequest } from './routes/sponsorDocs'; +import { handleSponsorDocRoutes, isAnonymousSponsorDocRequest, redirectLegacySponsorDocPath } from './routes/sponsorDocs'; import { handleClientErrorRoute, isClientErrorReport } from './routes/clientErrors'; import { handleEmailTemplateRoutes } from './routes/emailTemplates'; import { handleApiTokenRoutes } from './routes/apiTokens'; @@ -203,6 +203,9 @@ async function route(event: LambdaEvent, client: DynamoDBDocumentClient): Promis if (publisherResponse) return publisherResponse; } + const legacyDocRedirect = await redirectLegacySponsorDocPath(event, client); + if (legacyDocRedirect) return legacyDocRedirect; + // ── Single-origin portal layer (docs domain, flag-gated) ───── // When the docs domain is enabled, the portal serves the frontend, the docs // content API, and `/content/*`, and enforces the opaque browser session. A verified portal diff --git a/backend/src/routes/cards.ts b/backend/src/routes/cards.ts index fa404c6e..73a2a3d6 100644 --- a/backend/src/routes/cards.ts +++ b/backend/src/routes/cards.ts @@ -777,6 +777,9 @@ async function handleSingle( 'sourceDocIds', 'artifactRefs', 'intakeRefs', 'people', 'sponsor', 'secondarySponsors', 'issueNumber', 'sponsored', ]; + if (body.sponsored !== undefined && typeof body.sponsored !== 'boolean') { + return json(400, { error: 'sponsored must be a boolean' }); + } if (body.anchorDate !== undefined && body.anchorDate !== null && (typeof body.anchorDate !== 'string' || !/^\d{4}-\d{2}-\d{2}$/.test(body.anchorDate))) { return json(400, { error: 'Invalid anchorDate format, expected YYYY-MM-DD' }); diff --git a/backend/src/routes/sponsorDocs.ts b/backend/src/routes/sponsorDocs.ts index 306c68d6..86ee6242 100644 --- a/backend/src/routes/sponsorDocs.ts +++ b/backend/src/routes/sponsorDocs.ts @@ -54,6 +54,8 @@ import { FileStorageError } from '../storage'; import { savePublicImage } from '../publicImages'; import { extractMultipartImageBuffer, publicImagePayload } from './publicImages'; import { + LEGACY_PODCAST_DOC_TEMPLATES, + SPONSOR_DOC_CREATABLE_TEMPLATE_KEYS, SPONSOR_DOC_TEMPLATES, SponsorDocValidationError, getSponsorDocTemplate, @@ -174,7 +176,41 @@ function requestIp(event: LambdaEvent): string { export function sponsorDocPathForTemplate(template: string | null | undefined): string { if (template === 'webinar') return '/webinar-docs'; if (template === 'workshop') return '/workshop-docs'; - return template === 'podcast' ? '/podcast-docs' : '/sponsor-docs'; + if (template === 'podcast' || String(template || '').startsWith('podcast-')) return '/podcast-docs'; + return '/sponsor-docs'; +} + +/** + * Redirect legacy `/sponsor-docs/:id` requests for podcast/webinar/workshop + * documents to their canonical `/podcast-docs/:id` (or webinar/workshop) URL, + * preserving query parameters (e.g. `?code=...`). + */ +export async function redirectLegacySponsorDocPath( + event: LambdaEvent, + client: DynamoDBDocumentClient, +): Promise { + if ((event.httpMethod || 'GET').toUpperCase() !== 'GET') return null; + const match = /^\/sponsor-docs\/([^/?#]+)\/?$/.exec(event.path || ''); + if (!match) return null; + const docId = decodeURIComponent(match[1]); + const loaded = await getSponsorDocWithAuthMaterial(client, docId); + if (!loaded) return null; + const canonicalPrefix = sponsorDocPathForTemplate(loaded.doc.template); + if (canonicalPrefix === '/sponsor-docs') return null; + const rawQuery = event.queryStringParameters && Object.keys(event.queryStringParameters).length > 0 + ? `?${new URLSearchParams( + Object.entries(event.queryStringParameters).filter((e): e is [string, string] => typeof e[1] === 'string'), + ).toString()}` + : ''; + return { + statusCode: 302, + headers: { + Location: `${canonicalPrefix}/${encodeURIComponent(docId)}${rawQuery}`, + 'Cache-Control': 'no-store', + 'Referrer-Policy': 'no-referrer', + }, + body: '', + }; } export function sponsorDocPortalBaseUrl(event: LambdaEvent): string { @@ -522,7 +558,9 @@ export async function handleSponsorDocRoutes( if (m === 'GET' && /^\/templates\/?$/.test(suffix)) { const actor = await resolveInteractiveActor(client, event, 'work-read'); if (!actor.ok) return actor.response; - return json(200, { templates: Object.values(SPONSOR_DOC_TEMPLATES) }); + return json(200, { + templates: SPONSOR_DOC_CREATABLE_TEMPLATE_KEYS.map((key) => SPONSOR_DOC_TEMPLATES[key]), + }); } // Collection: GET /api/sponsor-docs, POST /api/sponsor-docs @@ -619,9 +657,9 @@ export async function handleSponsorDocRoutes( let template: SponsorDocTemplateKey; if (body.template !== undefined && body.template !== null && String(body.template).trim() !== '') { const requested = String(body.template).trim(); - if (!isSponsorDocTemplateKey(requested)) { + if (!isSponsorDocTemplateKey(requested) || LEGACY_PODCAST_DOC_TEMPLATES.includes(requested)) { return json(400, { - error: `Invalid template "${requested}". Must be one of: newsletter-main, newsletter-secondary, newsletter-standalone, webinar, podcast, podcast-guest-research, podcast-run-sheet, podcast-episode-brief`, + error: `Invalid template "${requested}". Must be one of: ${SPONSOR_DOC_CREATABLE_TEMPLATE_KEYS.join(', ')}`, code: 'invalid_template', }); } @@ -648,23 +686,13 @@ export async function handleSponsorDocRoutes( template = 'newsletter-main'; } - // Guest research and host run sheets start only after the date is - // confirmed (a recording date on the owning episode). The guest - // materials doc and the episode brief stay available before confirm. - if (template === 'podcast-guest-research' || template === 'podcast-run-sheet') { - const datedOwner = existingEpisode?.recordingDate - ? existingEpisode - : existingCard - ? (await listPodcastEpisodes(client)).find( - (episode) => episode.cardId === existingCard.id && episode.recordingDate, - ) - : undefined; - if (!datedOwner) { - return json(422, { - error: 'Guest research and run sheets start only after the date is confirmed: set the episode recording date first (dataops podcast update --recording-date YYYY-MM-DD).', - code: 'date_not_confirmed', - }); - } + // Event cards (podcast, webinar, workshop) never create sponsor-docs. + const cardType = existingCard ? (cardTemplateType(existingCard, templateIdByType) || '') : ''; + if ((existingEpisode || ['podcast', 'webinar', 'workshop'].includes(cardType)) && template.startsWith('newsletter-')) { + return json(422, { + error: 'Event cards (podcast, webinar, workshop) do not use sponsorship documents.', + code: 'event_card_no_sponsor_docs', + }); } // An event Card carries only its format's documents: a workshop @@ -685,6 +713,20 @@ export async function handleSponsorDocRoutes( return json(422, { error: 'Link this event document to a Card first.', code: 'event_card_required' }); } + // Enforce max ONE podcast document per podcast card. + const ownerForCheck = existingCard?.id || existingIssue?.id || existingEpisode?.id || ''; + if (template === 'podcast' && ownerForCheck) { + const existingDocs = await listSponsorDocSummariesByCardId(client, ownerForCheck); + const existingPodcastDoc = existingDocs.find((d) => d.template === 'podcast'); + if (existingPodcastDoc) { + return json(409, { + error: `This podcast card already has a guest document (${existingPodcastDoc.id}). Only one podcast document is allowed per card.`, + code: 'podcast_doc_already_exists', + existingDocId: existingPodcastDoc.id, + }); + } + } + const publicationDate = typeof body.publicationDate === 'string' && body.publicationDate.trim() ? body.publicationDate.trim() : existingIssue?.publicationDate @@ -1072,7 +1114,7 @@ export async function handleSponsorDocRoutes( const access = await resolveStaffOrSponsorAccess(client, event, 'work-write', body); if (access.isStaff) { - if (body.template !== undefined && !isSponsorDocTemplateKey(body.template)) { + if (body.template !== undefined && (!isSponsorDocTemplateKey(body.template) || LEGACY_PODCAST_DOC_TEMPLATES.includes(body.template))) { return json(400, { error: 'Unknown template', code: 'invalid_template' }); } const loaded = await getSponsorDocWithAuthMaterial(client, docId); diff --git a/backend/src/sponsorDocs/templates.ts b/backend/src/sponsorDocs/templates.ts index 183979be..5f674464 100644 --- a/backend/src/sponsorDocs/templates.ts +++ b/backend/src/sponsorDocs/templates.ts @@ -66,16 +66,24 @@ export interface SponsorDocTemplateDefinition { sections: SponsorDocSectionDefinition[]; } -export const SPONSOR_DOC_TEMPLATE_KEYS: readonly SponsorDocTemplateKey[] = [ +export const LEGACY_PODCAST_DOC_TEMPLATES: readonly SponsorDocTemplateKey[] = [ + 'podcast-guest-research', + 'podcast-run-sheet', + 'podcast-episode-brief', +] as const; + +export const SPONSOR_DOC_CREATABLE_TEMPLATE_KEYS: readonly SponsorDocTemplateKey[] = [ 'newsletter-main', 'newsletter-secondary', 'newsletter-standalone', 'webinar', 'workshop', 'podcast', - 'podcast-guest-research', - 'podcast-run-sheet', - 'podcast-episode-brief', +] as const; + +export const SPONSOR_DOC_TEMPLATE_KEYS: readonly SponsorDocTemplateKey[] = [ + ...SPONSOR_DOC_CREATABLE_TEMPLATE_KEYS, + ...LEGACY_PODCAST_DOC_TEMPLATES, ] as const; const VISUAL_GUIDELINES_URL = 'https://drive.google.com/file/d/1M_jEzcb1IWJmolx9N7e08gfdbctjcLH2/view?usp=sharing'; @@ -743,6 +751,99 @@ export const SPONSOR_DOC_TEMPLATES: Record { - for (const template of ['podcast', 'podcast-episode-brief']) { - const res = await req('POST', '/api/sponsor-docs', { - cardId: podcastCardId, template, autoSendEmail: false, - }); - assert.strictEqual(res.statusCode, 201, `${template}: ${res.body}`); - assert.strictEqual(payload(res).doc.template, template); - } + it('the podcast format\'s own document template creates once and rejects extras', async () => { + const res = await req('POST', '/api/sponsor-docs', { + cardId: podcastCardId, template: 'podcast', autoSendEmail: false, + }); + assert.strictEqual(res.statusCode, 201, res.body); + assert.strictEqual(payload(res).doc.template, 'podcast'); + + const briefRes = await req('POST', '/api/sponsor-docs', { + cardId: podcastCardId, template: 'podcast-episode-brief', autoSendEmail: false, + }); + assert.strictEqual(briefRes.statusCode, 400); + + const secondRes = await req('POST', '/api/sponsor-docs', { + cardId: podcastCardId, template: 'podcast', autoSendEmail: false, + }); + assert.strictEqual(secondRes.statusCode, 409); }); it('a template switch stays inside the Card\'s format', async () => { + const switchCard = payload(await createCard(podcastGit.id, { title: 'Switch Host Card' })).card; const fresh = await req('POST', '/api/sponsor-docs', { - cardId: podcastCardId, template: 'podcast', autoSendEmail: false, + cardId: switchCard.id, template: 'podcast', autoSendEmail: false, }); + assert.strictEqual(fresh.statusCode, 201, fresh.body); const freshId = payload(fresh).doc.id; - const stay = await req('PUT', `/api/sponsor-docs/${freshId}`, { template: 'podcast-episode-brief' }); - assert.strictEqual(stay.statusCode, 200); - assert.strictEqual(payload(stay).doc.template, 'podcast-episode-brief'); + const legacySwitch = await req('PUT', `/api/sponsor-docs/${freshId}`, { template: 'podcast-episode-brief' }); + assert.strictEqual(legacySwitch.statusCode, 400); const leave = await req('PUT', `/api/sponsor-docs/${freshId}`, { template: 'webinar' }); assert.strictEqual(leave.statusCode, 422); @@ -272,8 +281,9 @@ describe('Event format policy (three formats, format docs, sponsored flag)', () }); it('a created document with off-template content is rejected, not silently reshaped', async () => { + const offCard = payload(await createCard(podcastGit.id, { title: 'Off-template Host' })).card; const res = await req('POST', '/api/sponsor-docs', { - cardId: podcastCardId, template: 'podcast', autoSendEmail: false, + cardId: offCard.id, template: 'podcast', autoSendEmail: false, content: { guestName: 'Test Guest', freeformBanner: 'buy widgets' }, }); assert.strictEqual(res.statusCode, 422); @@ -351,17 +361,7 @@ describe('Event format policy (three formats, format docs, sponsored flag)', () content: PODCAST_GUEST_MATERIALS_CONTENT, status: 'submitted', }); assert.strictEqual(ok.statusCode, 200, ok.body); - } - const brief = payload(await req('POST', '/api/sponsor-docs', { - cardId: plain.id, template: 'podcast-episode-brief', autoSendEmail: false, - content: EPISODE_BRIEF_REQUIRED_CONTENT, - })).doc; - const flaggedBrief = payload(await req('POST', '/api/sponsor-docs', { - cardId: flagged.id, template: 'podcast-episode-brief', autoSendEmail: false, - content: EPISODE_BRIEF_REQUIRED_CONTENT, - })).doc; - for (const doc of [brief, flaggedBrief]) { - const deviation = await req('PUT', `/api/sponsor-docs/${doc.id}`, { + const deviation = await req('PUT', `/api/sponsor-docs/${docId}`, { content: { offTemplateField: 'x' }, }); assert.strictEqual(deviation.statusCode, 422); diff --git a/backend/tests/event-service.test.ts b/backend/tests/event-service.test.ts index 30433914..f509a9fe 100644 --- a/backend/tests/event-service.test.ts +++ b/backend/tests/event-service.test.ts @@ -453,7 +453,7 @@ describe('Unified Event Lifecycle Service & API (AC3, AC4, AC5, AC7, AC8, AC9)', cardId: card.id, }); - // Create linked guest materials doc and episode brief doc + // Create linked guest materials doc (one per podcast card) const guestDocRes = await invoke('POST', '/api/sponsor-docs', { cardId: card.id, template: 'podcast', @@ -461,13 +461,6 @@ describe('Unified Event Lifecycle Service & API (AC3, AC4, AC5, AC7, AC8, AC9)', assert.equal(guestDocRes.statusCode, 201, guestDocRes.body); const guestDoc = parse(guestDocRes).doc; - const briefDocRes = await invoke('POST', '/api/sponsor-docs', { - cardId: card.id, - template: 'podcast-episode-brief', - }); - assert.equal(briefDocRes.statusCode, 201, briefDocRes.body); - const briefDoc = parse(briefDocRes).doc; - // 1. PROPOSE on 2026-11-05 midday (12:30 Berlin) const proposeRes = await invoke('POST', `/api/events/${card.id}/propose`, { date: '2026-11-05', @@ -524,7 +517,7 @@ describe('Unified Event Lifecycle Service & API (AC3, AC4, AC5, AC7, AC8, AC9)', assert.equal(parse(driftCardRes).code, 'event_hold_owns_date'); // AC9: Linked docs reflect 2026-11-05 12:30 tentative live - for (const docId of [guestDoc.id, briefDoc.id]) { + for (const docId of [guestDoc.id]) { const liveDoc = parse(await invoke('GET', `/api/sponsor-docs/${docId}`)).doc; assert.equal(liveDoc.eventMetadata.date, '2026-11-05'); assert.equal(liveDoc.eventMetadata.time, '12:30'); @@ -553,7 +546,7 @@ describe('Unified Event Lifecycle Service & API (AC3, AC4, AC5, AC7, AC8, AC9)', // Invite task automatically completed on approve assert.equal((await getTask(client, inviteTask.id))?.status, 'done'); // Linked docs now show confirmed - for (const docId of [guestDoc.id, briefDoc.id]) { + for (const docId of [guestDoc.id]) { const liveDoc = parse(await invoke('GET', `/api/sponsor-docs/${docId}`)).doc; assert.equal(liveDoc.eventMetadata.state, 'confirmed'); assert.match(liveDoc.eventMetadata.label, /5 Nov 2026 12:30 Europe\/Berlin \(confirmed\)/); @@ -595,7 +588,7 @@ describe('Unified Event Lifecycle Service & API (AC3, AC4, AC5, AC7, AC8, AC9)', assert.equal(epAfterResched.recordingDate, '2026-12-01'); assert.equal(epAfterResched.recordingTime, '12:30'); assert.equal(epAfterResched.recordingEventStatus, 'proposed'); - for (const docId of [guestDoc.id, briefDoc.id]) { + for (const docId of [guestDoc.id]) { const liveDoc = parse(await invoke('GET', `/api/sponsor-docs/${docId}`)).doc; assert.equal(liveDoc.eventMetadata.date, '2026-12-01'); assert.equal(liveDoc.eventMetadata.state, 'tentative'); @@ -606,7 +599,7 @@ describe('Unified Event Lifecycle Service & API (AC3, AC4, AC5, AC7, AC8, AC9)', const reapproveRes = await invoke('POST', `/api/events/${card.id}/approve`, {}); assert.equal(reapproveRes.statusCode, 200, reapproveRes.body); assert.equal(parse(reapproveRes).event.status, 'approved'); - for (const docId of [guestDoc.id, briefDoc.id]) { + for (const docId of [guestDoc.id]) { const liveDoc = parse(await invoke('GET', `/api/sponsor-docs/${docId}`)).doc; assert.equal(liveDoc.eventMetadata.label, 'Tue, 1 Dec 2026 12:30 Europe/Berlin (confirmed)'); } @@ -620,7 +613,7 @@ describe('Unified Event Lifecycle Service & API (AC3, AC4, AC5, AC7, AC8, AC9)', for (const cal of [HOLD_ORGANIZER, ...DEFAULT_HOLD_GOOGLE_CALENDARS]) { assert.equal(googleMock.calendars.get(cal)!.size, 0, `Google event deleted on ${cal}`); } - for (const docId of [guestDoc.id, briefDoc.id]) { + for (const docId of [guestDoc.id]) { const liveDoc = parse(await invoke('GET', `/api/sponsor-docs/${docId}`)).doc; assert.equal(liveDoc.eventMetadata.state, 'released'); assert.equal(liveDoc.eventMetadata.label, 'Tue, 1 Dec 2026 12:30 Europe/Berlin (released)'); diff --git a/backend/tests/podcast-guest-form.test.ts b/backend/tests/podcast-guest-form.test.ts index 074a2fa9..b2791304 100644 --- a/backend/tests/podcast-guest-form.test.ts +++ b/backend/tests/podcast-guest-form.test.ts @@ -21,6 +21,8 @@ describe('podcast guest form (radio slot picker + topics; email stays one slot)' 'social-links', 'detailed-questions', 'notes', + 'episode-plan', + 'internal-research', ]); const fields = template.sections.flatMap((section) => section.fields); const keys = fields.map((field) => field.key); diff --git a/backend/tests/portal-doc-edit-task.test.ts b/backend/tests/portal-doc-edit-task.test.ts index 06508068..14ae924a 100644 --- a/backend/tests/portal-doc-edit-task.test.ts +++ b/backend/tests/portal-doc-edit-task.test.ts @@ -109,12 +109,11 @@ describe('portal doc edits create one open Task for the owner team', () => { assert.strictEqual((await portalTasks(card.id)).length, 0); }); - it('guest doc (podcast episode brief): edits raise one task naming doc, card and fields', async () => { + it('guest doc (podcast): edits raise one task naming doc, card and fields', async () => { const card = await createCard(client, { ...templateLink(), title: '[Podcast] 2026-12-01 - Jane Doe', anchorDate: '2026-12-01', people: ['Jane Doe'] }); await createPodcastEpisode(client, { title: 'Shipping ML features', guests: [{ name: 'Jane Doe' }], status: 'booked', recordingDate: '2026-12-01', cardId: card.id }); - const doc = await createDoc(card.id, 'podcast-episode-brief'); - const fieldKey = Object.keys(doc.content).find((key) => doc.content[key] === '' ) as string; - assert.ok(fieldKey, 'brief has an editable field'); + const doc = await createDoc(card.id, 'podcast'); + const fieldKey = 'guestName'; assert.strictEqual((await externalPut(doc.id, doc.accessCode, { [fieldKey]: 'Guest wrote this' })).statusCode, 200); await externalPut(doc.id, doc.accessCode, { [fieldKey]: 'Guest rewrote this' }); @@ -128,13 +127,11 @@ describe('portal doc edits create one open Task for the owner team', () => { }); it('different docs on one card keep separate tasks', async () => { - const card = await createCard(client, { ...templateLink(), title: '[Podcast] 2026-12-08 - Max Roe', anchorDate: '2026-12-08', people: ['Max Roe'] }); - await createPodcastEpisode(client, { title: 'Data contracts', guests: [{ name: 'Max Roe' }], status: 'booked', recordingDate: '2026-12-08', cardId: card.id }); - const a = await createDoc(card.id, 'podcast-episode-brief'); - const b = await createDoc(card.id, 'podcast'); - const key = (d: { content: Record }) => Object.keys(d.content).find((k) => d.content[k] === '') as string; - await externalPut(a.id, a.accessCode, { [key(a)]: 'x' }); - const resB = await externalPut(b.id, b.accessCode, { [key(b)]: 'y' }); + const card = await createCard(client, { ...templateLink(), title: '[Newsletter] (10 NOV 2026) #313 - Acme', anchorDate: '2026-11-10', sponsor: 'Acme', cardLinks: [{ name: 'Sponsorship document', url: '' }] }); + const a = await createDoc(card.id, 'newsletter-main'); + const b = await createDoc(card.id, 'newsletter-secondary'); + await externalPut(a.id, a.accessCode, { subjectLine: 'x' }); + const resB = await externalPut(b.id, b.accessCode, { title: 'y' }); assert.strictEqual(resB.statusCode, 200, resB.body); assert.strictEqual((await portalTasks(card.id)).length, 2); }); diff --git a/backend/tests/sponsor-docs.test.ts b/backend/tests/sponsor-docs.test.ts index 8db5fe73..d2fc3997 100644 --- a/backend/tests/sponsor-docs.test.ts +++ b/backend/tests/sponsor-docs.test.ts @@ -224,19 +224,17 @@ describe('Sponsor Content Docs API (/api/sponsor-docs)', () => { const { templates } = JSON.parse(templatesRes.body); assert.deepStrictEqual( templates.map((t: { key: string }) => t.key), - ['newsletter-main', 'newsletter-secondary', 'newsletter-standalone', 'webinar', 'workshop', 'podcast', 'podcast-guest-research', 'podcast-run-sheet', 'podcast-episode-brief'], + ['newsletter-main', 'newsletter-secondary', 'newsletter-standalone', 'webinar', 'workshop', 'podcast'], ); }); - it('creates podcast prep docs (guest research, run sheet, episode brief) with internal export and email drafts', async () => { + it('rejects legacy podcast prep templates, enforces max-1 podcast doc, blocks sponsor docs on event cards, and redirects legacy /sponsor-docs/ links', async () => { const card = await createCard(client, { ...templateLink(), title: '[Podcast] 2026-12-01 - Jane Doe', anchorDate: '2026-12-01', people: ['Jane Doe'], }); - // Post-confirm state: the episode carries the agreed recording date and - // links the Card. Research and run sheets are only available from here. const datedEpisode = await createPodcastEpisode(client, { title: 'Shipping ML features', guests: [{ name: 'Jane Doe' }], @@ -246,91 +244,36 @@ describe('Sponsor Content Docs API (/api/sponsor-docs)', () => { }); for (const template of ['podcast-guest-research', 'podcast-run-sheet', 'podcast-episode-brief'] as const) { - const createRes = await staffReq('POST', '/api/sponsor-docs', { - cardId: card.id, - template, - }); - assert.strictEqual(createRes.statusCode, 201, `${template}: ${createRes.body}`); - const created = JSON.parse(createRes.body); - assert.strictEqual(created.doc.template, template); - assert.strictEqual(created.doc.cardId, card.id); - assert.ok(created.doc.docUrl.includes('/sponsor-docs/')); - assert.ok(created.doc.emailDraft?.subject.includes('Podcast')); - const exportRes = await staffReq('GET', `/api/sponsor-docs/${created.doc.id}/export`, undefined, { - format: 'markdown', - }); - assert.strictEqual(exportRes.statusCode, 200); - assert.ok(exportRes.body.includes(created.doc.title)); + const createRes = await staffReq('POST', '/api/sponsor-docs', { cardId: card.id, template }); + assert.strictEqual(createRes.statusCode, 400, `${template}: ${createRes.body}`); + assert.strictEqual(JSON.parse(createRes.body).code, 'invalid_template'); } - // Episode-owned research doc works too once the date is confirmed. - const episodeOwned = await staffReq('POST', '/api/sponsor-docs', { - cardId: datedEpisode.id, - template: 'podcast-guest-research', - }); - assert.strictEqual(episodeOwned.statusCode, 201, episodeOwned.body); + const blockedSponsor = await staffReq('POST', '/api/sponsor-docs', { cardId: card.id, template: 'newsletter-main' }); + assert.strictEqual(blockedSponsor.statusCode, 422, blockedSponsor.body); + assert.strictEqual(JSON.parse(blockedSponsor.body).code, 'event_card_no_sponsor_docs'); - // Guest materials share email: form path only (no reply-instead wording). - const guestDoc = await staffReq('POST', '/api/sponsor-docs', { - cardId: datedEpisode.id, - template: 'podcast', - }); + const guestDoc = await staffReq('POST', '/api/sponsor-docs', { cardId: datedEpisode.id, template: 'podcast' }); assert.strictEqual(guestDoc.statusCode, 201, guestDoc.body); const guestCreated = JSON.parse(guestDoc.body); - assert.ok( - guestCreated.doc.docUrl.includes('/podcast-docs/'), - `podcast guest form lives under /podcast-docs/: ${guestCreated.doc.docUrl}`, - ); + assert.ok(guestCreated.doc.docUrl.includes('/podcast-docs/')); assert.strictEqual(guestCreated.doc.linkType, 'Guest materials'); - const guestBody = guestCreated.doc.emailDraft?.body || ''; - assert.match(guestBody, /use the form/i); - assert.match(guestBody, /do not invent alternate times/i); - assert.ok(!/couple of sentences/i.test(guestBody)); - assert.ok(!/either way works/i.test(guestBody)); - - const badRes = await staffReq('POST', '/api/sponsor-docs', { - cardId: card.id, - template: 'google-doc', - }); - assert.strictEqual(badRes.statusCode, 400, badRes.body); - assert.strictEqual(JSON.parse(badRes.body).code, 'invalid_template'); - }); - it('holds guest research and run sheets until the recording date is confirmed', async () => { - const card = await createCard(client, { - ...templateLink(), - title: '[Podcast] 2026-12-02 - John Roe', - anchorDate: '2026-12-02', - people: ['John Roe'], - }); - // A bare Card (invite sent, date not confirmed yet): research blocked, - // brief and guest materials stay available. - for (const template of ['podcast-guest-research', 'podcast-run-sheet'] as const) { - const blocked = await staffReq('POST', '/api/sponsor-docs', { - cardId: card.id, - template, - }); - assert.strictEqual(blocked.statusCode, 422, `${template}: ${blocked.body}`); - assert.strictEqual(JSON.parse(blocked.body).code, 'date_not_confirmed'); - } - const briefOk = await staffReq('POST', '/api/sponsor-docs', { - cardId: card.id, - template: 'podcast-episode-brief', - }); - assert.strictEqual(briefOk.statusCode, 201, briefOk.body); - - // A dateless episode (no confirmed recording date yet) is blocked too. - const dateless = await createPodcastEpisode(client, { - title: 'TBA topic', - guests: [{ name: 'John Roe' }], - status: 'booked', - }); - const blockedEpisode = await staffReq('POST', '/api/sponsor-docs', { - cardId: dateless.id, - template: 'podcast-run-sheet', - }); - assert.strictEqual(blockedEpisode.statusCode, 422, blockedEpisode.body); - assert.strictEqual(JSON.parse(blockedEpisode.body).code, 'date_not_confirmed'); + // Second podcast doc on the same card is rejected with 409. + const secondDoc = await staffReq('POST', '/api/sponsor-docs', { cardId: card.id, template: 'podcast' }); + assert.strictEqual(secondDoc.statusCode, 409, secondDoc.body); + assert.strictEqual(JSON.parse(secondDoc.body).code, 'podcast_doc_already_exists'); + + // Legacy /sponsor-docs/:id redirects to /podcast-docs/:id preserving ?code=. + const { redirectLegacySponsorDocPath } = await import('../src/routes/sponsorDocs'); + const redir = await redirectLegacySponsorDocPath({ + httpMethod: 'GET', + path: `/sponsor-docs/${guestCreated.doc.id}`, + queryStringParameters: { code: guestCreated.doc.accessCode }, + } as any, client); + assert.ok(redir); + assert.strictEqual(redir.statusCode, 302); + assert.strictEqual(redir.headers?.Location, `/podcast-docs/${guestCreated.doc.id}?code=${encodeURIComponent(guestCreated.doc.accessCode)}`); }); it('gates anonymous sponsor access by access code (query or header), allows sponsor edits & submission, and lets staff edit without a code', async () => { @@ -1092,68 +1035,43 @@ describe('Sponsor Content Docs API (/api/sponsor-docs)', () => { recordingDate: '2026-12-03', cardId: card.id, }); - const cases = [ - { - template: 'podcast-guest-research' as const, - content: { - guestName: 'PRIVATE-RESEARCH-GUEST', - sourceLinks: 'PRIVATE-RESEARCH-SOURCE', - keyInsights: 'PRIVATE-RESEARCH-FINDING', - hostOnlyNotes: 'PRIVATE-RESEARCH-HOST-NOTE', - }, - }, - { - template: 'podcast-run-sheet' as const, - content: { - guestName: 'PRIVATE-RUN-SHEET-GUEST', - coldOpen: 'PRIVATE-RUN-SHEET-OPEN', - questionBlocks: 'PRIVATE-RUN-SHEET-QUESTIONS', - hostNotes: 'PRIVATE-RUN-SHEET-NOTE', - }, + const createRes = await staffReq('POST', '/api/sponsor-docs', { + cardId: episode.id, + template: 'podcast', + content: { + guestName: 'Jane Doe', + interviewQuestions: 'SHARED-INTERVIEW-QUESTIONS', + sourceLinks: 'PRIVATE-RESEARCH-SOURCE', + keyInsights: 'PRIVATE-RESEARCH-FINDING', + openQuestions: 'PRIVATE-OPEN-QUESTIONS', + hostNotes: 'PRIVATE-RUN-SHEET-NOTE', }, - ]; - - for (const sample of cases) { - const createRes = await staffReq('POST', '/api/sponsor-docs', { - cardId: episode.id, - template: sample.template, - content: sample.content, - }); - assert.equal(createRes.statusCode, 201, `${sample.template}: ${createRes.body}`); - const { doc } = JSON.parse(createRes.body); - - const guestRes = await anonReq('GET', `/api/sponsor-docs/${doc.id}`, { codeHeader: doc.accessCode }); - assert.equal(guestRes.statusCode, 403, `${sample.template}: ${guestRes.body}`); - assert.equal(JSON.parse(guestRes.body).code, 'staff_only_document'); + }); + assert.equal(createRes.statusCode, 201, createRes.body); + const { doc } = JSON.parse(createRes.body); - const guestEdit = await anonReq('PUT', `/api/sponsor-docs/${doc.id}`, { - codeHeader: doc.accessCode, - body: { content: { guestName: 'GUEST-OVERWRITE' } }, - }); - assert.equal(guestEdit.statusCode, 403, `${sample.template}: ${guestEdit.body}`); + const guestRes = await anonReq('GET', `/api/sponsor-docs/${doc.id}`, { codeHeader: doc.accessCode }); + assert.equal(guestRes.statusCode, 200, guestRes.body); + const guestDoc = JSON.parse(guestRes.body).doc; + assert.equal(guestDoc.content.interviewQuestions, 'SHARED-INTERVIEW-QUESTIONS'); + assert.equal(guestDoc.content.sourceLinks, undefined); + assert.equal(guestDoc.content.hostNotes, undefined); - const guestSubmit = await anonReq('PUT', `/api/sponsor-docs/${doc.id}`, { - codeHeader: doc.accessCode, - body: { status: 'submitted' }, - }); - assert.equal(guestSubmit.statusCode, 403, `${sample.template}: ${guestSubmit.body}`); - - const guestExport = await anonReq('GET', `/api/sponsor-docs/${doc.id}/export`, { - codeHeader: doc.accessCode, - query: { format: 'markdown' }, - }); - assert.equal(guestExport.statusCode, 403, `${sample.template}: ${guestExport.body}`); - assert.equal(JSON.parse(guestExport.body).code, 'staff_only_document'); - - const staffRes = await staffReq('GET', `/api/sponsor-docs/${doc.id}`); - assert.equal(staffRes.statusCode, 200, `${sample.template}: ${staffRes.body}`); - const staffDoc = JSON.parse(staffRes.body).doc; - assert.equal(staffDoc.status, 'draft'); - assert.ok(staffDoc.templateDefinition.sections.every((section: { internal?: boolean }) => section.internal)); - for (const value of Object.values(sample.content)) { - assert.equal(JSON.stringify(staffDoc).includes(value), true, `${sample.template} staff view hid ${value}`); - } - } + const guestExport = await anonReq('GET', `/api/sponsor-docs/${doc.id}/export`, { + codeHeader: doc.accessCode, + query: { format: 'markdown' }, + }); + assert.equal(guestExport.statusCode, 200, guestExport.body); + assert.ok(guestExport.body.includes('SHARED-INTERVIEW-QUESTIONS')); + assert.ok(!guestExport.body.includes('PRIVATE-RESEARCH-SOURCE')); + assert.ok(!guestExport.body.includes('PRIVATE-RUN-SHEET-NOTE')); + + const staffRes = await staffReq('GET', `/api/sponsor-docs/${doc.id}`); + assert.equal(staffRes.statusCode, 200, staffRes.body); + const staffDoc = JSON.parse(staffRes.body).doc; + assert.equal(staffDoc.content.sourceLinks, 'PRIVATE-RESEARCH-SOURCE'); + assert.equal(staffDoc.content.hostNotes, 'PRIVATE-RUN-SHEET-NOTE'); + assert.ok(staffDoc.markdownExport.includes('PRIVATE-RESEARCH-SOURCE')); }); it('rejects switching a webinar form to the workshop type: documents stay inside the card format', async () => { @@ -1202,9 +1120,6 @@ describe('Sponsor Content Docs API (/api/sponsor-docs)', () => { }); it('copies every template to a new draft and exports real DOCX and Markdown', async () => { - // Each document template is copied between Cards of the format that owns - // it: event formats carry only their own documents, so podcast docs need - // podcast Cards and everything else lives on non-event Cards. function cardTitle(templateKey: string, role: 'source' | 'target'): string { if (templateKey === 'webinar') return `[Webinar] Copy ${role}`; if (templateKey === 'workshop') return `[Workshop] Copy ${role}`; @@ -1214,25 +1129,25 @@ describe('Sponsor Content Docs API (/api/sponsor-docs)', () => { const templates = JSON.parse((await staffReq('GET', '/api/sponsor-docs/templates')).body).templates; let lastTargetCardId: string | null = null; for (const template of templates) { - const sourceCard = await createCard(client, { ...templateLink(), title: cardTitle(template.key, 'source') }); - const targetCard = await createCard(client, { ...templateLink(), title: cardTitle(template.key, 'target') }); + const srcCard = await createCard(client, { ...templateLink(), title: cardTitle(template.key, 'source') }); + const tgtCard = await createCard(client, { ...templateLink(), title: cardTitle(template.key, 'target') }); if (template.key.startsWith('podcast')) { - for (const card of [sourceCard, targetCard]) { + for (const card of [srcCard, tgtCard]) { await createPodcastEpisode(client, { title: 'Confirmed', guests: [], status: 'booked', recordingDate: '2026-12-01', cardId: card.id }); } } - lastTargetCardId = targetCard.id; + lastTargetCardId = tgtCard.id; const fields = [...(template.fields || []), ...(template.sections || []).flatMap((section: { fields?: { key: string; type?: string; derived?: boolean }[] }) => section.fields || [])]; const field = fields.find((value: { type?: string; derived?: boolean }) => !value.derived && !['url', 'radio', 'select'].includes(value.type || '')) || fields[0]; - const original = await staffReq('POST', '/api/sponsor-docs', { cardId: sourceCard.id, template: template.key, title: `Copy ${template.key}`, content: { [field.key]: 'Authored text' } }); + const original = await staffReq('POST', '/api/sponsor-docs', { cardId: srcCard.id, template: template.key, title: `Copy ${template.key}`, content: { [field.key]: 'Authored text' } }); assert.equal(original.statusCode, 201, original.body); const source = JSON.parse(original.body).doc; - const copied = await staffReq('POST', '/api/sponsor-docs', { cardId: targetCard.id, from: source.id }); + const copied = await staffReq('POST', '/api/sponsor-docs', { cardId: tgtCard.id, from: source.id }); assert.equal(copied.statusCode, 201, copied.body); const copy = JSON.parse(copied.body).doc; assert.notEqual(copy.id, source.id); assert.notEqual(copy.accessCode, source.accessCode); - assert.equal(copy.cardId, targetCard.id); + assert.equal(copy.cardId, tgtCard.id); assert.equal(copy.template, template.key); assert.equal(copy.content[field.key], 'Authored text'); assert.equal(copy.status, 'draft'); @@ -1334,4 +1249,26 @@ describe('Sponsor Content Docs API (/api/sponsor-docs)', () => { assert.ok(!Object.hasOwn(guest, 'accessCode')); }); + it('appends access code to podcast calendar invite URLs and supports card sponsored flag', async () => { + const card = await createCard(client, { ...templateLink(), title: '[Podcast] Invite Code Test', people: ['Ada'] }); + const createRes = await staffReq('POST', '/api/sponsor-docs', { cardId: card.id, template: 'podcast' }); + assert.equal(createRes.statusCode, 201); + const { doc, card: updatedCard } = JSON.parse(createRes.body); + const { resolveGuestDocumentUrlWithCode } = await import('../src/calendar/cardInvite'); + const resolved = await resolveGuestDocumentUrlWithCode(client, `https://ops.dtcdev.click/podcast-docs/${doc.id}`); + assert.equal(resolved, `https://ops.dtcdev.click/podcast-docs/${doc.id}?code=${encodeURIComponent(doc.accessCode)}`); + + const { handleCardRoutes } = await import('../src/routes/cards'); + const rawBody = JSON.stringify({ expectedVersion: updatedCard.version, sponsored: true }); + const patchRes = await handleCardRoutes( + `/api/cards/${card.id}`, + 'PUT', + rawBody, + { httpMethod: 'PUT', path: `/api/cards/${card.id}`, headers: { 'x-user-id': 'test-admin' }, body: rawBody } as any, + client, + ); + assert.ok(patchRes && patchRes.statusCode === 200, patchRes?.body); + assert.equal(JSON.parse(patchRes!.body).card.sponsored, true); + }); + }); diff --git a/cli/src/commands/cards.mjs b/cli/src/commands/cards.mjs index 605bb5c7..c8812d3f 100644 --- a/cli/src/commands/cards.mjs +++ b/cli/src/commands/cards.mjs @@ -194,9 +194,12 @@ export async function show(args, io) { for (const task of result.tasks) { if (task.linkedCard) io.print(`task link: ${task.description} -> ${linkedCardLabel(task.linkedCard)} ${portalUrl(api, task.linkedCard.url)}`); } + const legacyPodcastTemplates = new Set(["podcast-episode-brief", "podcast-guest-research", "podcast-run-sheet"]); for (const doc of card.sponsorDocs || []) { + if (legacyPodcastTemplates.has(doc.template)) continue; const edited = doc.lastEditedAt ? `, last edited ${doc.lastEditedAt} by ${doc.lastEditedBy || "staff"}` : ""; - io.print(`sponsor doc: ${doc.id} [${doc.status}] (${doc.template}${edited})`); + const kind = ["podcast", "webinar", "workshop"].includes(doc.template) ? "guest doc" : "sponsor doc"; + io.print(`${kind}: ${doc.id} [${doc.status}] (${doc.template}${edited})`); } io.print(""); table( diff --git a/cli/src/commands/sponsorDocs.mjs b/cli/src/commands/sponsorDocs.mjs index 71ffb551..dd3dabec 100644 --- a/cli/src/commands/sponsorDocs.mjs +++ b/cli/src/commands/sponsorDocs.mjs @@ -11,9 +11,6 @@ export const TEMPLATES = [ "webinar", "workshop", "podcast", - "podcast-guest-research", - "podcast-run-sheet", - "podcast-episode-brief", ]; /** Domains whose form the event speaker fills, one template each. */ @@ -21,9 +18,6 @@ const SPEAKER_DOMAINS = ["webinar", "workshop"]; export const PODCAST_TEMPLATES = [ "podcast", - "podcast-guest-research", - "podcast-run-sheet", - "podcast-episode-brief", ]; export const newsletterDocHelp = `dataops newsletter doc - portal-hosted newsletter sponsor content documents @@ -44,11 +38,10 @@ Usage dataops newsletter doc rotate-code `; -export const podcastDocHelp = `dataops podcast doc - portal-hosted podcast documents (guest materials + prep docs) +export const podcastDocHelp = `dataops podcast doc - portal-hosted podcast guest document (one per podcast card) Usage - dataops podcast doc create [--template podcast|podcast-guest-research|podcast-run-sheet|podcast-episode-brief] - [--from DOC-ID] [--title T] [--sponsor NAME] [--date YYYY-MM-DD] [--link-type NAME] [--email] + dataops podcast doc create [--from DOC-ID] [--title T] [--guest NAME] [--date YYYY-MM-DD] [--link-type NAME] [--email] dataops podcast doc show dataops podcast doc export [--format md|docx|txt] [--output PATH] dataops podcast doc delete --yes @@ -60,14 +53,7 @@ Usage dataops podcast doc rotate-code dataops podcast doc templates -Prep templates (default: podcast): - podcast guest-facing materials from the guest (default, optional for the guest — - a short email reply works instead of filling the form) - podcast-guest-research internal source-backed guest research (staff-only, after date confirm) - podcast-run-sheet internal one-page host run sheet (staff-only, after date confirm) - podcast-episode-brief episode planning brief (replaces Google Doc brief) -Research and run sheets start only after the recording date is confirmed -(dataops podcast update --recording-date YYYY-MM-DD). +Each podcast card has at most one document (template: podcast) at /podcast-docs/sdoc-*. `; export const webinarDocHelp = `dataops webinar doc - webinar speaker materials @@ -248,7 +234,8 @@ export async function create(args, io) { const title = optionalString(args, "title"); if (title !== undefined) body.title = title; - const sponsorName = optionalString(args, SPEAKER_DOMAINS.includes(domain) ? "speaker" : "sponsor"); + const sponsorName = optionalString(args, SPEAKER_DOMAINS.includes(domain) ? "speaker" : domain === "podcast" ? "guest" : "sponsor") + ?? (domain === "podcast" ? optionalString(args, "sponsor") : undefined); if (sponsorName !== undefined) body.sponsorName = sponsorName; const date = isoDate(optionalString(args, "date"), "date"); @@ -322,6 +309,8 @@ export async function list(args, io) { const payload = { ...result, docs }; if (args.json) return payload; + const whoCol = args._domain === "podcast" ? "GUEST" : SPEAKER_DOMAINS.includes(args._domain) ? "SPEAKER" : "SPONSOR"; + const emptyMsg = args._domain === "podcast" ? "No podcast documents found." : "No sponsor documents found."; table( io, docs, @@ -330,11 +319,11 @@ export async function list(args, io) { ["STATUS", (doc) => doc.status], ["TEMPLATE", (doc) => doc.template], ["DATE", (doc) => doc.publicationDate || ""], - ["SPONSOR", (doc) => doc.sponsorName || ""], + [whoCol, (doc) => doc.sponsorName || ""], ["LAST EDITED", (doc) => (doc.lastEditedAt ? `${doc.lastEditedAt.slice(0, 16).replace("T", " ")} (${doc.lastEditedBy || "staff"})` : "never")], ["TITLE", (doc) => doc.title], ], - "No sponsor documents found.", + emptyMsg, ); return payload; } @@ -348,13 +337,16 @@ export async function show(args, io) { const payload = { ...result, doc }; if (args.json) return payload; + const whoLabel = doc.template === "podcast" || String(doc.template || "").startsWith("podcast-") + ? "guest" + : SPEAKER_DOMAINS.includes(doc.template) ? "speaker" : "sponsor"; fields(io, [ ["id", doc.id], ["card", doc.cardId], ["title", doc.title], ["template", `${doc.template} (${doc.templateDefinition?.label || ""})`], ["status", doc.status === "submitted" ? "submitted (ready)" : "draft"], - ["sponsor", doc.sponsorName], + [whoLabel, doc.sponsorName], ["publication date", doc.publicationDate], ["card link slot", doc.linkType], ["canonical url", doc.docUrl], diff --git a/cli/test/cli.test.mjs b/cli/test/cli.test.mjs index d3a68342..0b714947 100644 --- a/cli/test/cli.test.mjs +++ b/cli/test/cli.test.mjs @@ -753,9 +753,8 @@ describe("newsletter doc and podcast doc commands", () => { const ioPrep = captureIo(); assert.equal( await run(["podcast", "doc", "create", "card-pod-1", "--template", "podcast-run-sheet", "--url", "https://ops.dtcdev.click"], ioPrep), - 0, + 2, ); - assert.equal(sent[3].template, "podcast-run-sheet"); const ioBadTemplate = captureIo(); assert.equal( @@ -768,7 +767,7 @@ describe("newsletter doc and podcast doc commands", () => { await run(["newsletter", "doc", "submit", "doc-123", "--url", "https://ops.dtcdev.click"], ioSubmit), 0, ); - assert.equal(sent[4].status, "submitted"); + assert.equal(sent[3].status, "submitted"); assert.match(ioSubmit.text(), /Updated sponsor doc doc-123 \[submitted\]/); const ioExport = captureIo(); @@ -783,7 +782,7 @@ describe("newsletter doc and podcast doc commands", () => { await run(["podcast", "doc", "delete", "doc-123", "--yes", "--url", "https://ops.dtcdev.click"], ioDelete), 0, ); - assert.deepEqual(sent[5], { deleted: "doc-123" }); + assert.deepEqual(sent[4], { deleted: "doc-123" }); assert.match(ioDelete.text(), /Deleted sponsor doc doc-123/); globalThis.fetch = globalFetch; diff --git a/frontend/src/surfaces/operations/sponsor-doc-guest-schedule.js b/frontend/src/surfaces/operations/sponsor-doc-guest-schedule.js index aa0cf344..f952ac29 100644 --- a/frontend/src/surfaces/operations/sponsor-doc-guest-schedule.js +++ b/frontend/src/surfaces/operations/sponsor-doc-guest-schedule.js @@ -41,6 +41,34 @@ export function appendTimeChoiceSave({ fieldWrap, actionBtn, busy, draftContent, }, busy)); } +export function renderPodcastQuestionsView({ el, draftContent }) { + const qCard = el("div", "sponsor-doc-card sponsor-doc-questions-view"); + qCard.dataset.podcastQuestionsView = "readonly"; + const qHead = el("div", "sponsor-doc-title-row"); + qHead.append(el("h2", "sponsor-doc-section__title", "Episode Questions (Read-only recording view)")); + qCard.append(qHead); + const qFields = [ + ["Cold Open", draftContent.coldOpen], + ["Intro Script", draftContent.introScript], + ["Interview Questions", draftContent.interviewQuestions], + ["Topics to Cover", draftContent.topicsToCover], + ["Topics to Avoid", draftContent.topicsToAvoid], + ["Closing Script", draftContent.closingScript], + ]; + let hasAny = false; + for (const [labelText, val] of qFields) { + const text = String(val || "").trim(); + if (!text) continue; + hasAny = true; + const sec = el("div", "sponsor-doc-section"); + sec.append(el("h3", "sponsor-doc-field__label", labelText)); + sec.append(el("pre", "sponsor-doc-export-pre", text)); + qCard.append(sec); + } + if (!hasAny) qCard.append(el("p", "dk-hint", "No questions or topics added to this document yet.")); + return qCard; +} + export function guestEventMetadataRow({ el, doc, tDef, draftContent, isSpeakerDoc, isPodcastGuestDoc, formatEditorLabel }) { const metaRow = el("div", "sponsor-doc-meta"); metaRow.append(el("span", "dk-badge", tDef.label || doc.template)); diff --git a/frontend/src/surfaces/operations/sponsor-doc-visual.js b/frontend/src/surfaces/operations/sponsor-doc-visual.js index d79438b6..cd3346ca 100644 --- a/frontend/src/surfaces/operations/sponsor-doc-visual.js +++ b/frontend/src/surfaces/operations/sponsor-doc-visual.js @@ -27,9 +27,10 @@ export function mountSponsorDocVisualControls({ const visualControls = el("div", "sponsor-doc-visual-upload"); visualControls.dataset.sponsorVisualControls = fieldDef.key; + const isPhotoField = fieldDef.key === "photoUrl"; const fileInputId = `sponsor-visual-file-${fieldDef.key}`; const uploadClass = "dk-button dk-button--secondary dk-button--sm sponsor-doc-visual-upload__label"; - const uploadLabel = el("label", uploadClass, "Upload visual"); + const uploadLabel = el("label", uploadClass, isPhotoField ? "Upload photo" : "Upload visual"); uploadLabel.setAttribute("for", fileInputId); const fileInput = el("input", "sponsor-doc-visual-upload__input"); @@ -80,7 +81,14 @@ export function mountSponsorDocVisualControls({ const v = String(rawVal || "").trim(); visualPreview.replaceChildren(); if (!v) { - visualPreview.hidden = true; + if (isPhotoField) { + visualPreview.hidden = false; + const placeholder = el("p", "dk-hint sponsor-doc-photo-placeholder", "No photo yet — upload a portrait or paste an image URL to see a preview."); + placeholder.dataset.sponsorPhotoPlaceholder = ""; + visualPreview.append(placeholder); + } else { + visualPreview.hidden = true; + } return; } visualPreview.hidden = false; @@ -103,7 +111,7 @@ export function mountSponsorDocVisualControls({ } } - const clearBtn = actionBtn("dk-button dk-button--secondary dk-button--sm", "Remove visual", "clear-visual", () => { + const clearBtn = actionBtn("dk-button dk-button--secondary dk-button--sm", isPhotoField ? "Remove photo" : "Remove visual", "clear-visual", () => { setUploadedVisualName(""); draftContent[fieldDef.key] = ""; control.value = ""; diff --git a/frontend/src/surfaces/operations/sponsor-docs.js b/frontend/src/surfaces/operations/sponsor-docs.js index aff75bf1..119cc6ae 100644 --- a/frontend/src/surfaces/operations/sponsor-docs.js +++ b/frontend/src/surfaces/operations/sponsor-docs.js @@ -1,4 +1,4 @@ -import { appendGuestTimezoneSelector, appendTimeChoiceSave, guestSlotFieldDefinition, guestEventMetadataRow } from "./sponsor-doc-guest-schedule.js"; +import { appendGuestTimezoneSelector, appendTimeChoiceSave, guestSlotFieldDefinition, guestEventMetadataRow, renderPodcastQuestionsView } from "./sponsor-doc-guest-schedule.js"; import { formatEditedTimestamp } from "../../core/dates.js"; import { formatUserCode } from "../../dakit/device-code.js"; import { renderSponsorDocGate } from "./sponsor-doc-gate.js"; @@ -94,8 +94,8 @@ function extractDocId(pathname) { /** Podcast guest form reads as guest materials everywhere, never sponsor. */ function isPodcastGuestDoc(doc) { - return String(doc?.template || doc?.templateDefinition?.key || "") === "podcast" - || String(doc?.templateDefinition?.key || "") === "podcast"; + const key = String(doc?.template || doc?.templateDefinition?.key || ""); + return key === "podcast" || key.startsWith("podcast-"); } /** Webinar and workshop forms are filled by the speaker. */ @@ -133,6 +133,7 @@ export function createSponsorDocPage({ let draftContent = {}; let fieldErrors = {}; let uploadedVisualName = ""; + let questionsOnly = false; let phase = "loading"; let gateError = ""; let feedbackMsg = ""; @@ -402,6 +403,18 @@ export function createSponsorDocPage({ const badge = el("span", badgeClass, isSubmitted ? "Submitted / Ready" : "Draft"); badge.dataset.sponsorDocStatus = doc.status; titleRow.append(el("h1", "sponsor-doc-title", formTitle), badge); + if (isPodcastGuestDoc(doc)) { + const viewQBtn = actionBtn( + "dk-button dk-button--secondary dk-button--sm", + questionsOnly ? "Back to form" : "View questions", + "toggle-questions-view", + () => { + questionsOnly = !questionsOnly; + render(); + }, + ); + titleRow.append(viewQBtn); + } const { metaRow, guestSchedule, guestZone } = guestEventMetadataRow({ el, doc, tDef, draftContent, isSpeakerDoc, isPodcastGuestDoc, formatEditorLabel, @@ -417,8 +430,13 @@ export function createSponsorDocPage({ staffBar.dataset.sponsorStaffBar = ""; const topRow = el("div", "sponsor-doc-staff-bar__row"); const shareInfo = el("div", ""); + const linkLabel = isSpeakerDoc(doc) + ? "Shareable speaker link (includes access code): " + : isPodcastGuestDoc(doc) + ? "Shareable guest link (includes access code): " + : "Shareable sponsor link (includes access code): "; shareInfo.append( - el("strong", "", isSpeakerDoc(doc) ? "Shareable speaker link (includes access code): " : "Shareable sponsor link (includes access code): "), + el("strong", "", linkLabel), el("code", "dk-mono", doc.shareUrl || doc.docUrl || ""), ); topRow.append(shareInfo); @@ -506,6 +524,11 @@ export function createSponsorDocPage({ root.append(headerCard); + if (questionsOnly && isPodcastGuestDoc(doc)) { + root.append(renderPodcastQuestionsView({ el, draftContent })); + return; + } + // 2. Editor form card + optional Live Preview pane const showLivePreview = isNewsletterTemplate(doc.template, tDef); root.classList.toggle("sponsor-doc-shell--with-preview", showLivePreview); @@ -925,6 +948,7 @@ export function createSponsorDocPage({ const extracted = extractDocId(url.pathname); docId = extracted.id; docPathPrefix = SPONSOR_DOC_PATH_PREFIXES.includes(extracted.prefix) ? extracted.prefix : "/sponsor-docs"; + questionsOnly = url.searchParams.get("view") === "questions"; const queryCode = url.searchParams.get("code"); if (queryCode !== null) { accessCode = formatUserCode(queryCode); diff --git a/frontend/src/surfaces/podcast/detail.js b/frontend/src/surfaces/podcast/detail.js index 9aa154bb..b642fcef 100644 --- a/frontend/src/surfaces/podcast/detail.js +++ b/frontend/src/surfaces/podcast/detail.js @@ -60,6 +60,19 @@ function closeButton(documentRef, actions) { function statusSection(documentRef, episode, actions, messages) { const section = element(documentRef, "section", "podcast-section podcast-status-section"); section.setAttribute("aria-label", "Status"); + const docUrl = episode.card?.podcastDocUrl || episode.podcastDocUrl; + if (docUrl) { + const docRow = element(documentRef, "div", "podcast-guest-doc-top"); + docRow.dataset.podcastGuestDocLink = ""; + const docLabel = element(documentRef, "strong", "", "Guest document: "); + const docLink = element(documentRef, "a", "dk-link"); + docLink.href = docUrl; + docLink.target = "_blank"; + docLink.rel = "noopener noreferrer"; + docLink.textContent = docUrl; + docRow.append(docLabel, docLink); + section.append(docRow); + } const row = element(documentRef, "div", "dk-cluster podcast-status-row"); const code = episodeCode(episode); if (code) row.append(element(documentRef, "span", "dk-mono podcast-code", code)); diff --git a/frontend/src/surfaces/work-detail/card-documents.js b/frontend/src/surfaces/work-detail/card-documents.js index 913f010d..e317882f 100644 --- a/frontend/src/surfaces/work-detail/card-documents.js +++ b/frontend/src/surfaces/work-detail/card-documents.js @@ -1,4 +1,5 @@ -import { renderCardSponsorDocsSection } from './card-summary.js'; +import { opensInNewTab } from '../../core/links.js'; +import { isEventCard, renderCardSponsorDocsSection, visibleCardDocs } from './card-summary.js'; const drafts = new Map(); const workspaces = new WeakMap(); @@ -178,6 +179,163 @@ export function renderCardDocuments({ card, request, workApiUrl }) { return section; } +/** + * Top-of-card quick bar for event cards: + * - Podcast: immediate `/podcast-docs/` link (AC12) + one-click live questions preview (AC19) + * - All event cards (podcast, webinar, workshop): optional "Sponsored" flag toggle (AC18) + */ +export function renderCardEventQuickBar({ card, request, workApiUrl, reload }) { + if (!isEventCard(card)) return null; + const docs = visibleCardDocs(card); + const podcastDoc = docs.find((d) => String(d.template || '') === 'podcast'); + const podcastLinkFromCard = (card.cardLinks || []).find((l) => /\/podcast-docs\/[^/?#]+/.test(String(l.url || ''))); + const podcastDocUrl = podcastDoc + ? `/podcast-docs/${encodeURIComponent(podcastDoc.id)}` + : (podcastLinkFromCard?.url || ''); + + const bar = document.createElement('section'); + bar.className = 'workflow-detail-section card-event-quick-bar'; + bar.dataset.cardEventQuickBar = ''; + + const row = document.createElement('div'); + row.className = 'card-newsletter-slot__row'; + + if (podcastDocUrl) { + const docLink = document.createElement('a'); + docLink.href = podcastDocUrl; + docLink.className = 'dk-button dk-button--secondary dk-button--sm'; + docLink.dataset.cardPodcastDocTopLink = ''; + docLink.textContent = 'Open Guest Document (/podcast-docs/)'; + opensInNewTab(docLink); + row.append(docLink); + } + + let previewPanel = null; + if (podcastDoc || card.qna?.url) { + const qBtn = document.createElement('button'); + qBtn.type = 'button'; + qBtn.className = 'dk-button dk-button--primary dk-button--sm'; + qBtn.dataset.cardLiveQuestionsTrigger = ''; + qBtn.textContent = 'Live questions preview'; + row.append(qBtn); + + previewPanel = document.createElement('div'); + previewPanel.className = 'card-live-questions-preview'; + previewPanel.dataset.cardLiveQuestionsPanel = ''; + previewPanel.hidden = true; + + qBtn.addEventListener('click', async () => { + if (!previewPanel.hidden) { + previewPanel.hidden = true; + qBtn.textContent = 'Live questions preview'; + return; + } + qBtn.disabled = true; + qBtn.textContent = 'Loading questions…'; + previewPanel.replaceChildren(); + try { + const [docResult, qnaResult] = await Promise.allSettled([ + podcastDoc ? request(workApiUrl(`/api/sponsor-docs/${encodeURIComponent(podcastDoc.id)}`)) : Promise.resolve(null), + card.qna?.url ? request(workApiUrl(`/api/cards/${encodeURIComponent(card.id)}/qna/questions`)) : Promise.resolve(null), + ]); + const docContent = docResult.status === 'fulfilled' ? (docResult.value?.doc?.content || {}) : {}; + const preparedFields = [ + ['Cold open', docContent.coldOpen], + ['Intro script', docContent.introScript], + ['Interview questions', docContent.interviewQuestions], + ['Topics to cover', docContent.topicsToCover], + ['Topics to avoid', docContent.topicsToAvoid], + ['Closing script', docContent.closingScript], + ].filter(([, val]) => String(val || '').trim()); + + const prepHeading = document.createElement('strong'); + prepHeading.textContent = 'Podcast questions & run flow'; + previewPanel.append(prepHeading); + if (preparedFields.length) { + for (const [label, val] of preparedFields) { + const block = document.createElement('div'); + block.className = 'card-live-questions-block'; + const h = document.createElement('div'); + h.className = 'dk-hint'; + h.textContent = label; + const pre = document.createElement('pre'); + pre.className = 'card-live-questions-text'; + pre.textContent = String(val).trim(); + block.append(h, pre); + previewPanel.append(block); + } + } else { + const emptyPrep = document.createElement('p'); + emptyPrep.className = 'dk-hint'; + emptyPrep.textContent = 'No prepared questions in the podcast document yet.'; + previewPanel.append(emptyPrep); + } + + const qnaQuestions = qnaResult.status === 'fulfilled' && Array.isArray(qnaResult.value?.questions) + ? qnaResult.value.questions + : (Array.isArray(card.qna?.questions) ? card.qna.questions : []); + const qnaHeading = document.createElement('strong'); + qnaHeading.textContent = `Audience Q&A questions (${qnaQuestions.length})`; + previewPanel.append(qnaHeading); + if (qnaQuestions.length) { + const list = document.createElement('ol'); + list.className = 'card-qna__questions'; + for (const q of qnaQuestions) { + const li = document.createElement('li'); + li.textContent = `${q.text} — ${q.authorName || 'Anonymous'}${q.score > 1 ? ` (+${q.score})` : ''}${q.status === 'answered' ? ' ✓ answered' : ''}`; + list.append(li); + } + previewPanel.append(list); + } else { + const emptyQna = document.createElement('p'); + emptyQna.className = 'dk-hint'; + emptyQna.textContent = card.qna?.url ? 'No audience questions yet.' : 'No Q&A room linked to this card.'; + previewPanel.append(emptyQna); + } + + previewPanel.hidden = false; + qBtn.textContent = 'Hide live questions'; + } catch (err) { + const errP = document.createElement('p'); + errP.className = 'dk-hint'; + errP.textContent = `Could not load questions: ${err?.message || 'request failed'}`; + previewPanel.append(errP); + previewPanel.hidden = false; + qBtn.textContent = 'Hide live questions'; + } finally { + qBtn.disabled = false; + } + }); + } + + const sponsoredLabel = document.createElement('label'); + sponsoredLabel.className = 'card-sponsored-toggle'; + const sponsoredCheck = document.createElement('input'); + sponsoredCheck.type = 'checkbox'; + sponsoredCheck.checked = card.sponsored === true; + sponsoredCheck.dataset.cardSponsoredToggle = ''; + sponsoredCheck.addEventListener('change', async () => { + sponsoredCheck.disabled = true; + try { + await request(workApiUrl(`/api/cards/${encodeURIComponent(card.id)}`), { + method: 'PUT', + body: JSON.stringify({ expectedVersion: card.version, sponsored: sponsoredCheck.checked }), + }); + await reload?.(); + } catch { + sponsoredCheck.checked = card.sponsored === true; + } finally { + sponsoredCheck.disabled = false; + } + }); + sponsoredLabel.append(sponsoredCheck, document.createTextNode(' Sponsored')); + row.append(sponsoredLabel); + + bar.append(row); + if (previewPanel) bar.append(previewPanel); + return bar; +} + /** Keep the Card panel's document composition in one section owner. */ export function renderCardDocumentSections(context) { const shared = renderCardSponsorDocsSection(context.card); diff --git a/frontend/src/surfaces/work-detail/card-panel.js b/frontend/src/surfaces/work-detail/card-panel.js index 49c8e435..46337fbb 100644 --- a/frontend/src/surfaces/work-detail/card-panel.js +++ b/frontend/src/surfaces/work-detail/card-panel.js @@ -1,4 +1,4 @@ -import { renderCardDocumentSections } from './card-documents.js'; +import { renderCardDocumentSections, renderCardEventQuickBar } from './card-documents.js'; import { afterText, blockedReason, blockingPrerequisites, prerequisiteStatusLabel } from "../../core/task-dependencies.js"; import { taskTitleParts } from "../../core/task-display.js"; import { @@ -403,6 +403,8 @@ export function createCardPanel(context) { ), ); main.append(meta); + const eventQuickBar = renderCardEventQuickBar({ card, request, workApiUrl, reload: reloadCardIntent }); + if (eventQuickBar) main.append(eventQuickBar); const invitation = renderCardGuestInvitation({ request, workApiUrl, reload: reloadCardIntent }, card); if (invitation) main.append(invitation); main.append(renderCardNewsletterIssue({ request, workApiUrl, reload: reloadCardIntent }, card)); diff --git a/frontend/src/surfaces/work-detail/card-summary.js b/frontend/src/surfaces/work-detail/card-summary.js index 9d96005e..41d5df09 100644 --- a/frontend/src/surfaces/work-detail/card-summary.js +++ b/frontend/src/surfaces/work-detail/card-summary.js @@ -147,12 +147,43 @@ const DOC_KINDS = { podcast: { path: "podcast-docs", label: "Guest materials" }, }; +const LEGACY_PODCAST_TEMPLATES = new Set([ + "podcast-episode-brief", + "podcast-guest-research", + "podcast-run-sheet", +]); + +const EVENT_CARD_TYPES = new Set(["podcast", "webinar", "workshop"]); + +export function isEventCard(card) { + const type = String(card?.templateDefinitionSnapshot?.type || card?.templateType || "").toLowerCase(); + if (EVENT_CARD_TYPES.has(type)) return true; + const docs = Array.isArray(card?.sponsorDocs) ? card.sponsorDocs : []; + return docs.some((d) => { + const t = String(d?.template || ""); + return EVENT_CARD_TYPES.has(t) || t.startsWith("podcast-"); + }); +} + +export function visibleCardDocs(card) { + const raw = Array.isArray(card?.sponsorDocs) ? card.sponsorDocs : []; + const eventCard = isEventCard(card); + return raw.filter((doc) => { + const tpl = String(doc?.template || ""); + if (LEGACY_PODCAST_TEMPLATES.has(tpl)) return false; + if (eventCard && tpl.startsWith("newsletter-")) return false; + return true; + }); +} + function docKind(doc) { - return DOC_KINDS[String(doc.template || "")] || { path: "sponsor-docs", label: "Sponsor document" }; + const tpl = String(doc.template || ""); + if (tpl.startsWith("podcast-")) return DOC_KINDS.podcast; + return DOC_KINDS[tpl] || { path: "sponsor-docs", label: "Sponsor document" }; } export function renderCardSponsorDocsSection(card) { - const docs = Array.isArray(card?.sponsorDocs) ? card.sponsorDocs : []; + const docs = visibleCardDocs(card); if (!docs.length) return null; const section = document.createElement("div"); section.className = "task-history workflow-detail-section card-sponsor-docs-section"; @@ -445,7 +476,7 @@ export function createCardSummary(context) { chip.textContent = `${flag.count} ${flag.label}`; flagRow.append(chip); } - const sponsorDocs = Array.isArray(card.sponsorDocs) ? card.sponsorDocs : []; + const sponsorDocs = visibleCardDocs(card); for (const sdoc of sponsorDocs) { const chip = document.createElement("small"); const isSubmitted = sdoc.status === "submitted"; @@ -455,6 +486,13 @@ export function createCardSummary(context) { chip.textContent = isSubmitted ? `${kindLabel}: Submitted / Ready` : `${kindLabel}: Draft`; flagRow.append(chip); } + if (card.sponsored === true) { + const sponsoredChip = document.createElement("small"); + sponsoredChip.className = "workflow-card-flag is-info"; + sponsoredChip.dataset.cardSponsoredFlag = "true"; + sponsoredChip.textContent = "Sponsored"; + flagRow.append(sponsoredChip); + } summaryTop.append(countRow); if (flagRow.children.length > 0) summaryTop.append(flagRow); summaryTop.append(stageLabel); diff --git a/frontend/test/sponsor-docs.test.mjs b/frontend/test/sponsor-docs.test.mjs index d88ce8f9..25dcd3e0 100644 --- a/frontend/test/sponsor-docs.test.mjs +++ b/frontend/test/sponsor-docs.test.mjs @@ -828,3 +828,86 @@ test("guest brief renders uploaded photo inline immediately and shows visible er assert.match(brokenErr.textContent, /Could not load image/); h.controller.destroy(); }); + +test("podcast cards hide legacy prep templates, never show Sponsorship documents, and expose top link + live questions + sponsored flag", async () => { + const prevDoc = globalThis.document; + globalThis.document = new FakeDocument(); + try { + const { renderCardEventQuickBar } = await import("../src/surfaces/work-detail/card-documents.js"); + const card = { + id: "card-pod-1", + version: 3, + templateDefinitionSnapshot: { type: "podcast" }, + sponsored: true, + qna: { url: "https://qna.dtcdev.click/r/pod1" }, + sponsorDocs: [ + { id: "sdoc-pod", template: "podcast", status: "draft", title: "Guest doc" }, + { id: "sdoc-brief", template: "podcast-episode-brief", status: "submitted", title: "Brief" }, + { id: "sdoc-res", template: "podcast-guest-research", status: "draft", title: "Research" }, + { id: "sdoc-run", template: "podcast-run-sheet", status: "draft", title: "Run sheet" }, + ], + }; + const section = renderCardSponsorDocsSection(card); + assert.match(section.textContent, /Guest materials/); + assert.doesNotMatch(section.textContent, /Sponsorship document/i); + assert.equal(section.querySelectorAll("[data-sponsor-doc-id]").length, 1); + assert.ok(section.querySelector('[data-sponsor-doc-id="sdoc-pod"]')); + + const calls = []; + const bar = renderCardEventQuickBar({ + card, + workApiUrl: (p) => p, + reload: async () => {}, + request: async (url) => { + calls.push(url); + if (url.includes("/api/sponsor-docs/")) { + return { doc: { content: { interviewQuestions: "1. What is FDE?" } } }; + } + if (url.includes("/qna/questions")) { + return { questions: [{ text: "How do you test agents?", authorName: "Alex", score: 2, status: "visible" }] }; + } + return {}; + }, + }); + assert.ok(bar.querySelector('[data-card-podcast-doc-top-link]').href.includes("/podcast-docs/sdoc-pod")); + assert.equal(bar.querySelector('[data-card-sponsored-toggle]').checked, true); + + await bar.querySelector('[data-card-live-questions-trigger]').click(); + await nextTicks(); + assert.ok(calls.some((u) => u.includes("/api/sponsor-docs/sdoc-pod"))); + assert.ok(calls.some((u) => u.includes("/api/cards/card-pod-1/qna/questions"))); + const panel = bar.querySelector('[data-card-live-questions-panel]'); + assert.equal(panel.hidden, false); + assert.match(panel.textContent, /1\. What is FDE\?/); + assert.match(panel.textContent, /How do you test agents\?/); + } finally { + globalThis.document = prevDoc; + } +}); + +test("podcast doc supports read-only view-questions mode and photo preview placeholder", async () => { + const definition = podcastTemplateDefinition(); + definition.sections[1].fields.push({ key: "photoUrl", label: "Photo", type: "text", allowVisualUpload: true }); + const h = harness({ + href: "https://ops.example.test/podcast-docs/doc-q?code=bcdfghjklmnpqrst", + pathname: "/podcast-docs/doc-q", + docOverrides: { + template: "podcast", + templateDefinition: definition, + content: { + interviewQuestions: "Q1: Why agents?\nQ2: How evals?", + topicsToCover: "Production reliability", + }, + }, + }); + await h.controller.start(); + assert.ok(h.root.querySelector('[data-sponsor-photo-placeholder]'), "empty photoUrl shows preview placeholder"); + await h.root.querySelector('[data-sponsor-action="toggle-questions-view"]').click(); + await nextTicks(); + const ro = h.root.querySelector('[data-podcast-questions-view="readonly"]'); + assert.ok(ro); + assert.match(ro.textContent, /Q1: Why agents\?/); + assert.match(ro.textContent, /Production reliability/); + assert.equal(h.root.querySelector('[data-sponsor-action="submit-ready"]'), null); + h.controller.destroy(); +});