Repository navigation
Conversation
The `//:gazelle_downloader_configs` filegroup referenced `gazelle/downloader_cfg.bazelrc` and `gazelle/downloader_config.cfg` as plain labels. That only works in the rules_python dev workspace, where `.bazelrc.deleted_packages` disables `//gazelle`. When rules_python is used as an external repository that contains `gazelle/BUILD.bazel` (e.g. via `git_override` or `local_path_override`), these labels cross a package boundary and are invalid, so loading any target in the root package fails, e.g. `@rules_python//:LICENSE`. Use a `glob` with `allow_empty = True` instead. It does not cross package boundaries, so it is empty for external users and still picks up the files in the dev workspace.
Collaborator
Author
The gazelle filegroup now uses a glob, so the root BUILD.bazel no longer lists the synced file names for it. Point the sphinxdocs block at the sync script to keep the remaining pair checked.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
//:gazelle_downloader_configsfilegroup referencedgazelle/downloader_cfg.bazelrcandgazelle/downloader_config.cfgasplain labels. That only works in the rules_python dev workspace, where
.bazelrc.deleted_packagesdisables//gazelle. When rules_python is usedas an external repository that contains
gazelle/BUILD.bazel(e.g. viagit_overrideorlocal_path_override), these labels cross a packageboundary and are invalid, so loading any target in the root package fails:
This becomes a blocker once every target depends on a root package target,
e.g. the default
package_metadataadded in #4276.Use a
globwithallow_empty = Trueinstead. It does not cross packageboundaries, so it is empty for external users and still picks up the files in
the dev workspace, where
//tests/dev:sync_downloader_configs_testconsumesthem.