Skip to content

Cape Town | 26-ITP-Sept | Leigh Ross | Sprint 2 | Coursework sprint 2 - #1503

Open
leigh-ross wants to merge 20 commits into
CodeYourFuture:mainfrom
leigh-ross:coursework/sprint-2
Open

leigh-ross wants to merge 20 commits into
CodeYourFuture:mainfrom
leigh-ross:coursework/sprint-2

Conversation

@leigh-ross

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1083

Changelist

Sprint 2 changes:

  • Implemented: contains, createLookup, parseQueryString, tally, invert
  • invert: added non-object error handling + bracket-notation swap
  • Added tests for all functions and all pass
  • Predict-and-explain write-ups: object-to-string, for...in, dot notation

leigh-ross and others added 10 commits November 6, 2026 00:23
…ingle object with key value pairs (each array being a k-v pair). Implemented test. Test passes. Using Object method
…an object with key and value pairs, using guidance from already written test cases. All tests pass
…cy of each item then returns an object with each item-frequency pair. Implemented tests and all tests pass.
…d bracket notation to assign propeties which handles swopping key-value pairs. Added test file and tests. all tests pass
@leigh-ross leigh-ross added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 11, 2026

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use prettier to format the code in all files to keep the code consistently formatted?

Comment thread Sprint-2/implement/contains.test.js Resolved
Comment thread Sprint-2/implement/querystring.js Resolved
Comment thread Sprint-2/implement/querystring.js Resolved
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 16, 2026
…ry string. Moved decoding to the for block. Added tests to check querystrings containing '=' in the actual value and '+' and '%' values in the same string. All tests now pass
@leigh-ross leigh-ross added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 18, 2026
@leigh-ross
leigh-ross requested a review from cjyuan November 18, 2026 10:28
Comment thread Sprint-2/implement/querystring.js Resolved
Comment thread Sprint-2/interpret/invert.js Resolved
Comment thread Sprint-2/implement/contains.test.js Resolved
Comment thread Sprint-2/interpret/invert.js Resolved
Comment thread Sprint-2/debug/author.js Resolved
@cyf-ai-code-reviewer cyf-ai-code-reviewer Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 18, 2026
@cyf-ai-code-reviewer

Copy link
Copy Markdown

The CYF AI review has left comments. It will only review a PR one time. When you have addressed these comments, please request review again and a volunteer will take a look.

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes you made in querystring.js introduces a bug, which was detected by the ai-code-reviewer.

I think you should also address the issues raised by the ai-reviewer.

@leigh-ross leigh-ross added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 18, 2026
@leigh-ross
leigh-ross requested a review from cjyuan November 18, 2026 14:02

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

Comment thread Sprint-2/implement/querystring.test.js Resolved
@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants