Repository navigation
Cape Town | 26-ITP-Sept | Leigh Ross | Sprint 2 | Coursework sprint 2 - #1503
Open
leigh-ross wants to merge 20 commits into
Open
leigh-ross wants to merge 20 commits into
leigh-ross wants to merge 20 commits into
Conversation
…mplemented tests. All tests pass
…ingle object with key value pairs (each array being a k-v pair). Implemented test. Test passes. Using Object method
…an object with key and value pairs, using guidance from already written test cases. All tests pass
…cy of each item then returns an object with each item-frequency pair. Implemented tests and all tests pass.
…d bracket notation to assign propeties which handles swopping key-value pairs. Added test file and tests. all tests pass
cjyuan
reviewed
Nov 16, 2026
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Could you use prettier to format the code in all files to keep the code consistently formatted?
… boolean, null, undefined
…contains requires an object not an array.
…ry string. Moved decoding to the for block. Added tests to check querystrings containing '=' in the actual value and '+' and '%' values in the same string. All tests now pass
|
The CYF AI review has left comments. It will only review a PR one time. When you have addressed these comments, please request review again and a volunteer will take a look. |
cjyuan
reviewed
Nov 18, 2026
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
The changes you made in querystring.js introduces a bug, which was detected by the ai-code-reviewer.
I think you should also address the issues raised by the ai-reviewer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task code
CYF-1083
Changelist
Sprint 2 changes: