Repository navigation
5e6fd577: stale docs/CI leftovers, CLI aliases, legacy view routes; Trello importer decision prepared - #334
Merged
Merged
Conversation
…aths (5e6fd577) content/, _docs/, templates/ and scripts/deploy/ no longer exist in the repo (the process corpus moved to DataTalksClub/dataops-knowledge in 1b6e9b2, _docs/scripts-deploy in 990e046/63afe3b4), so their workflow path filters can never match. The guarded entries in validate-planning-docs.yml required by scripts/validate_planning_docs.py REQUIRED_WORKFLOW_PATHS (_docs/**, templates/**, docs/**) stay; only the unguarded leftovers (content/**, content/tasks/templates/**, scripts/deploy/**) are removed. Also drop the dead 'search-index' entry from the Makefile .PHONY line: no such target exists. Evidence: ls of content/ _docs/ templates/ scripts/deploy/ all missing; git log shows the removing commits; tests/planning_docs + tests/infra pass (62 passed) after the change.
'dataops offers set' was an alias of 'offers update' and 'dataops crm touches' an alias of 'crm touch'; neither name appears in any help text, cli/skill/SKILL.md, cli/README.md, tests or other docs, and the repo rules forbid undocumented compatibility aliases. Evidence: grep for 'offers set' and 'crm touches' across the repo and bots-management skills returns nothing; cli --help texts document only update/touch. cli tests offers/crm/cli (53 tests) pass after removal.
The account menu still linked 'CLI sessions' to /device/sessions, but the /device approval page, its frontend surface and the CLI-session token list were deleted in 4f50bb2 (API tokens and device grants retired; cli-sessions.js, device.html, device.css, surfaces/operations/device.js all removed). The path has no backend route and no workspace route: the SPA parses it as an unknown path and falls back to the docs library. Evidence: grep for device/sessions and CLI sessions across backend/src, frontend/src, frontend/test and backend/e2e returns no handler and no test; the only reference was this index.html link.
README.md: remove the content/ layout bullet (corpus moved to the private dataops-knowledge repo), point the architecture diagram at the knowledge repo, correct 'single workspace' to backend/ + cli/, and drop the nonexistent 'npm run export:templates:backend' root script. backend/README.md: correct 'backend/ as the single Node package' to the two workspaces, rewrite the Build and Project Structure sections that still described src/public/ and src/pages/ (deleted; the artifact now packages the canonical frontend/ app), and replace the 'dops_svc_' invoice-reader credential section (removed in 4f50bb2) with the shared-issuer credential model. docs/README.md: remove the 'content/ - transitional operational documentation' section and the archive/ bullet (both gone), and drop the stale 'reads operational docs from content/ until private knowledge-repo sync is implemented' claim - that sync shipped. docs/local-development.md: the search-index example pointed at --content-dir ../content, which no longer exists; use the knowledge checkout like the neighbouring docs-links example. Evidence: ls shows content/, backend/src/public, backend/src/pages and docs/archive missing; root package.json has no export:templates:backend; grep finds no dops_svc_/InvoiceReaderTokenSha256 references in backend/src, infra or the deploy workflow. tests/planning_docs passes (62 passed) after the edits.
alexeygrigorev
added a commit
that referenced
this pull request
Nov 4, 2026
…e (already implemented), pin the retired offers set alias (#341) Handoff 0f847429 asked for ONE structured, CLI/API-queryable rate card record. Verification on origin/main (982bb8e) and live prod shows the gap was already closed by d2e96f9 (2026-10-31, pushed directly to main) and the prod record seeded the same day (version 1, 15 offers / 6 non-offers / 9 inbound-routing rules); PR #334 removed the undocumented 'offers set' alias. No product code changes were needed. What this adds: - DONE-0f847429.md: the re-verification evidence (inventory with file references, seed provenance, live read-only prod checks, test results, remaining gaps). - cli/test/offers.test.mjs: negative pin that 'dataops offers set' stays inert — unknown subcommand, usage exit, no portal call (house style per the 2026-08-13 test suite review and PR #335), so the #334 cleanup cannot silently regress. Tests: cli/test/offers.test.mjs 6/6, backend/tests/offers.test.ts 2/2, backend typecheck clean on this tree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task 5e6fd577 — cleanup inventory + safe removals of unambiguously dead items. Worktree
fix/stale-docs-cleanup(baseorigin/main@ f2da8e6). Per the task, nothing here is merged, and the Trello importer decision is prepared but NOT made.Inventory
Removed (unambiguously dead, with zero-usage evidence)
deploy-dataops-v1.ymlpath filterscontent/**,scripts/deploy/**(push+PR)content/removed in 1b6e9b2 (corpus moved to dataops-knowledge);scripts/deploy/removed in 63afe3b.lsboth missing; no test/validator references them.validate-dataops-content.ymlpath filtercontent/**(push+PR)content/removal; filter can never match.validate-planning-docs.ymlpath filtercontent/tasks/templates/**(push+PR)content/gone. The validator-required filters (_docs/**,templates/**,docs/**) are kept —scripts/validate_planning_docs.pyREQUIRED_WORKFLOW_PATHS enforces them.search-indexentry in.PHONYsearch-index:target exists; no doc/test referencesmake search-index.offers setalias ofoffers update(cli/src/commands/offers.mjs)cli/skill/SKILL.md,cli/README.md; grep "offers set" over repo + bots-management skills: zero hits; no test calls it.crm touchesalias ofcrm touch(cli/src/commands/crm.mjs)crm touch; grep "crm touches": zero hits (tests only hit the API path/api/sponsor-crm/touches)./device/sessions(frontend/index.html)cli-sessions.js,device.html,device.css,surfaces/operations/device.jswere deleted in 4f50bb2 (API tokens + device grants retired). No backend route, no workspace route (parseWorkspaceLocation→ "unknown path" → falls back to docs library). Only reference was this link.README.md:content/layout bullet; mermaid "GitHub repo: content/ markdown"; "single workspace is backend/"; nonexistentnpm run export:templates:backendcontent/missing; root package.json workspaces = backend+cli; noexport:templates:backendscript anywhere.backend/README.md: "backend/ as the single Node package"; Build + Project Structure describingsrc/public/andsrc/pages/; whole "Agent and invoice reader service credential" (dops_svc_) sectionbackend/src/publicandbackend/src/pagesmissing; build script packagesfrontend/via copy-frontend-artifact;dops_svc_/InvoiceReaderTokenSha256removed in 4f50bb2 (zero grep hits in backend/src, infra, workflows).docs/README.md: "content/ - transitional operational documentation" section,archive/bullet, "reads operational docs from content/ ... until private knowledge-repo sync is implemented"docs/archive/missing; the knowledge-repo sync shipped (deploy workflowDOCS_GITHUB_REPO: dataops-knowledge).docs/local-development.md: search-index example--content-dir ../content../contentmissing; aligned with the neighbouring--content-root ../dataops-knowledge/contentexample.Kept for decision (used by prod data / ambiguous)
backend/scripts/import-trello-csv.ts(2.1k lines) + 3 test files (trello-import-{templates,assignee,loom}.test.ts)npm testglobtests/*.test.ts). Its bundled data (backend/data/qVB6fAUG - datatalksclub.json,TODO list - todo/done.csv) is absent from the repo and was never committed (git log -- backend/dataempty), so without external--source*files the script cannot run.backend/docs/data.md(its analysis) IS still referenced by.goal-v1.md, JTBD docs and enforced byvalidate_planning_docs.py. Delete = remove script + 3 test files; the original Trello migration is long done and re-import data is gone.WORKSPACE_ROUTE_DEFINITIONSpath is linked (sidebarindex.html,sponsor-routes.jsCRM nav,planning-newsletter.jsissue links) and covered byfrontend/test/routing.test.mjs.surface-composition.jsshowWorkspaceSurfacelegacy "search"/"processes" view names anddataset.workspaceTargethave zero producers (grep). Tiny; safe to remove later.docs/STRUCTURE.md,docs/sop-format.md(content/-era corpus conventions).knowledge/content(frontmatter/IDs); a rewrite to point at the knowledge repo is a content decision, not a removal.backend/docs/historical specs (specs.md,data.md,templates.md, parts)validate_planning_docs.pyrequires JTBD docs to reference them;.goal-v1.mdlists them.validate-dataops-content.ymltrigger inconsistency: push includesdocs/**, pull_request does notbackend/package.jsonvalidate:docs-linksdefault--content-root content--content-root .knowledge/content. Changing the default is a small fix but affects bare local runs — left for decision.DONE-*.mdsession evidence files (9 files, Nov 2-4)Checks run
uv run --with pytest python -m pytest tests/planning_docs tests/infra— 62 passed (covers Makefile-help contract, workflow trigger/execution contracts, planning docs links).npm run test:cli(workspaces dataops-cli) — same result as pristineorigin/mainin this environment: 4 pre-existing Windows-env failures (tokens.test.mjs,headless scoped agent tokens,managed-engine sessions,invoice PDF), verified identical withgit stashon clean main. Targetednode --test test/offers.test.mjs test/crm.test.mjs test/cli.test.mjs: 53/53 pass.node --test frontend/test/{routing,frontend-architecture,dakit-tokens,app-coordinator}.test.mjs— identical to pristine main (2 pre-existing failures in CSS/readability contracts on files not touched here); the routing and nav-structure contracts overindex.htmlpass with the menu-link removal.Files changed
.github/workflows/deploy-dataops-v1.yml,.github/workflows/validate-dataops-content.yml,.github/workflows/validate-planning-docs.yml,Makefile,README.md,backend/README.md,cli/src/commands/crm.mjs,cli/src/commands/offers.mjs,docs/README.md,docs/local-development.md,frontend/index.html(11 files, +23/-63).Commits:
0c954ee9(CI),770a98d5(CLI aliases),2b458328(portal link),ab4a1058(docs).