Repository navigation
Conversation
Builds everything a package or a wheel ships, without the tests: libraries, binaries and Python modules. CI jobs that only package or run the Python tests no longer compile the C++ tests (cmake --build . -t deliverables). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
BotellaA
pushed a commit
to Geode-solutions/actions
that referenced
this pull request
Nov 17, 2026
Replaces the lookup of the folder targets (Geode-solutions/OpenGeode#1412), falls back to building everything with older OpenGeode releases. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With GEODE_CI_DEBUG_FLAGS (CI test builds), Debug builds no longer use link-time optimization: the links redid the optimization of every object. Measured on Geode-Common (clang, CI flags): -36% CPU for a full build, -79% after a one-file change. Release builds keep it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
BotellaA
pushed a commit
to Geode-solutions/actions
that referenced
this pull request
Nov 17, 2026
Requires an OpenGeode release with the deliverables target (Geode-solutions/OpenGeode#1412) in every repository. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pybind11-stubgen and mypy.stubtest import the binding modules in their own process, which did not import geode_test_env: on Windows, the DLLs of the dependencies were not found (DLL load failed while importing ...), and test-py-stubs and test-py-wrapper-stubs failed. The CI did not report it: the Windows Python job ignored the ctest failures. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Merged into #1411, which now includes these changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.
deliverablestargetWhy
Some CI jobs need everything a package or a wheel ships, but not the tests. The Linux Python test job, for example, compiles every C++ test just to run the Python tests, which
build-linuxalready covers. Today the only way to build "everything except the tests" is to list folder targets (src/geode/all,src/bin/all,bindings/python/all), and those differ between repos (Geode-solutions/actions#111).What
A new custom target,
deliverables, created next toessentialandthird_partyinGlobalOptions.cmake. It depends on every:add_geode_library),add_geode_binary),add_geode_python_binding).cmake --build . -t deliverablesthen builds whatcpackand thewheeltarget need, without the tests. It follows the same pattern asessential.2. No link-time optimization in CI Debug builds
Why
CppTargets.cmaketurns on link-time optimization (LTO) whenever the compiler supports it, Debug builds included. In the CI test builds that means-flto=thin(clang),-flto(gcc) and/GL+/LTCG(MSVC). The links then redo the optimization of every object, for binaries that are only tested once. Links also can't be cached, which would cap what a compiler cache could save.Measured locally on Geode-Common, CPU time, with the CI flags (
-O2 -D_GLIBCXX_ASSERTIONS, clang, unity on):What
When
GEODE_CI_DEBUG_FLAGSis set (only the CI test builds set it),CMAKE_INTERPROCEDURAL_OPTIMIZATION_DEBUGis set toOFF:I checked these three cases on a minimal CMake project with clang, by looking for
-fltoin the generated compile commands.It's an environment variable, so it also reaches the inner project of superbuild repos, which a
-Doption on the outer configure wouldn't.3. Fix: stub gates on Windows (from #1411)
Bug
On Windows,
test-py-stubsandtest-py-wrapper-stubsfail:check_python_stubs.pyrunspybind11-stubgenandmypy.stubtestin their own process. That process didn't importgeode_test_env, which adds the dependency DLL folders (GEODE_DLL_DIRECTORIES). Since Python 3.8, Windows no longer searchesPATHfor the DLLs of an extension module. The other Python tests pass because they importgeode_test_envthemselves.The CI didn't report it: the Windows Python test job ignored
ctestfailures (PowerShell without stop-on-error). Seen on Geode-Common_private (next): 2 of 9 Python tests failed, and the job was still green.Fix
Both tools now run through a small wrapper (
python_module_command). It importsgeode_test_envwhen it's available (it isn't for thewheeltarget, which runs the same gates), then runs the module likepython -m, with the same arguments and exit code. Checked locally with a standard-library module.🤖 Generated with Claude Code