Repository navigation
Conversation
legalsylvain
marked this pull request as draft
May 20, 2026 06:00
dnplkndll
force-pushed
the
19.0-mig-attachment_synchronize
branch
11 times, most recently
from
May 20, 2026 15:54
46aa944 to
50fac2f
Compare
Contributor
Author
|
@florian-dacosta @sebastienbeau Depends on #3614 Two test fixtures rebuilt for the no-demo CI posture: setUpClass creates the fs.storage backend + import/export tasks inline (was env.ref to fs_storage.fs_storage_demo and own demo XML, neither loaded in CI); test_import.py uses self.registry_enter_test_mode() in place of the gone Registry.enter_test_mode(cr) |
dnplkndll
marked this pull request as ready for review
May 20, 2026 16:46
dnplkndll
force-pushed
the
19.0-mig-attachment_synchronize
branch
2 times, most recently
from
May 29, 2026 20:22
4e063e4 to
50fac2f
Compare
dnplkndll
force-pushed
the
19.0-mig-attachment_synchronize
branch
from
June 22, 2026 18:33
50fac2f to
ce73c7e
Compare
Contributor
|
@dnplkndll can you rebase/remove tracking_manager (also #3614) |
- match pattern filename to download - empty list as default domain
- prefer enabled in place of active
- log info on run completed
…ng files even if the path ends with the folder separator
Currently translated at 100.0% (67 of 67 strings) Translation: server-tools-16.0/server-tools-16.0-attachment_synchronize Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-attachment_synchronize/it/
Currently translated at 4.4% (3 of 67 strings) Translation: server-tools-16.0/server-tools-16.0-attachment_synchronize Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-attachment_synchronize/es/
Currently translated at 100.0% (67 of 67 strings) Translation: server-tools-16.0/server-tools-16.0-attachment_synchronize Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-attachment_synchronize/es/
Currently translated at 100.0% (67 of 67 strings) Translation: server-tools-16.0/server-tools-16.0-attachment_synchronize Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-attachment_synchronize/it/
…ver : If one task is failing, keep processing the others Commit fir attachment imported after each file to be sure not to loose any data, when deleting on remote after import for example
Currently translated at 100.0% (76 of 76 strings) Translation: server-tools-16.0/server-tools-16.0-attachment_synchronize Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-attachment_synchronize/it/
Currently translated at 100.0% (76 of 76 strings) Translation: server-tools-16.0/server-tools-16.0-attachment_synchronize Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-attachment_synchronize/it/
The goal is to be able easy overrides to pass custom parameters to the fsspec open method
It was like this before and it is now supported by sshfs. open + read is slower and less reliable
…because of timeout
Currently translated at 100.0% (76 of 76 strings) Translation: server-tools-16.0/server-tools-16.0-attachment_synchronize Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-attachment_synchronize/it/
dnplkndll
force-pushed
the
19.0-mig-attachment_synchronize
branch
from
November 19, 2026 14:34
ce73c7e to
cb51f98
Compare
CRogos
approved these changes
Nov 19, 2026
CRogos
left a comment
Contributor
There was a problem hiding this comment.
Code LGTM, but not tested.
| This module allows to **import/export files** from/to backend servers. | ||
|
|
||
| A backend server is defined by the basic | ||
| [fs_storage](https://github.com/OCA/storage/tree/16.0/fs_storage) OCA |
Contributor
There was a problem hiding this comment.
Update version ore are relative links possible?
Signed-off-by: Don Kendall <dkendall@ledoweb.com> Assisted-by: Claude Opus 5
* Delete migrations/18.0.1.0.0/ (T08) * odoo.osv.expression → odoo.fields.Domain * tracking_disable=True added to SyncCommon.setUpClass * Test fixtures (fs.storage backend + tasks) built inline in setUpClass; demo XML ships its own fs.storage record (fs_storage 19.0 dropped fs_storage_demo) * Registry.enter_test_mode(cr) → self.registry_enter_test_mode() in test_import.py Signed-off-by: Don Kendall <dkendall@ledoweb.com> Assisted-by: Claude Opus 5
Pip-installs attachment_queue from the upstream PR branch via whool until merge. Signed-off-by: Don Kendall <dkendall@ledoweb.com> Assisted-by: Claude Opus 5
dnplkndll
force-pushed
the
19.0-mig-attachment_synchronize
branch
from
November 20, 2026 00:11
cb51f98 to
8f9f543
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of
attachment_synchronizefrom 18.0 to 19.0. Follows the OCA migration guide.Depends on #3614. The
[DO NOT MERGE]commit installsattachment_queueviawhoolfrom the open-PR branch until #3614 merges and the 19.0 wheel publishes; the pin is reverted before merge.Non-mechanical adaptations:
fs.storagebackend + 6 tasks) built inline intests/common.py::setUpClass— OCA CI doesn't load demo data, andfs_storage19.0 also dropped itsfs_storage_demorecord.Registry.enter_test_mode(cr)→self.registry_enter_test_mode()intest_import.py(API moved from the Registry to the TestCase in 19).AI-assisted (Claude Code); every change reviewed, tested, and owned by the author.