Repository navigation
Conversation
The module shipped a JS unit test but no HttpCase runner, so it never ran in CI. Add the runner, and adapt the test to the 19.0 form layout: core now renders the form sheet + chatter side by side only at >= XXL (stacking them as `flex-column` below that), and the toggle is intentionally hidden in the stacked layout. The test now forces the wide/sided layout, mocks the chatter the same way mail compiles it, and asserts on the chatter's own state so it is deterministic regardless of test order or runner viewport.
Assisted-by: Claude Opus 5.5
- Owl 3: useState is replaced by proxy (owl3-migration). - Font Awesome angle icons replaced by Material Symbols keyboard_arrow_right/left, in the template, the runtime fallback button and the SCSS (19.5-00-material-symbols-icons). - The template keeps `__comp__` without `this.`: it is t-called from the compiled form template, whose context only holds `__comp__`. - JS test: SIZES moved to @web/core/ui/ui_utils. Assisted-by: Claude Opus 5.5
|
The following commit authors need to sign the Contributor License Agreement: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #3582 (19.0 migration, not merged yet): its commits are included and keep their original author.
Changes for 20.0:
useStatereplaced byproxy(owl3-migration).keyboard_arrow_right/left(template, runtime fallback button and SCSS).
__comp__withoutthis.: it is t-called from the compiled formtemplate, whose context only holds
__comp__(the owl3 script would addthis.).SIZESmoved to@web/core/ui/ui_utils.Tested on Odoo 20: the 6 Hoot tests pass; on the partner form at XXL width the chatter
collapses and is restored, and the toggle is hidden in the stacked layout.
AI-assisted: Claude Opus 5.5 (commits carry the
Assisted-by:trailer, per OCA AI policy).