Repository navigation
fix(types): widen color props to ColorValue (#5179) - #5193
EnesKartal wants to merge 1 commit into
Conversation
|
Found potential problems with the pull request:
|
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
CI fails on Lint. Prettier wants the |
|
Thanks, pushed the Prettier fix for |
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
0a6e2a5 to
d515c23
Compare
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Summary
Fixes #5179
Theme color roles are typed
ColorValue, but several component color props were stillstring, so passing theme orPlatformColorvalues failed to compile (TS2322). This widens them toColorValueinProgressBar,Appbar.Content,Avatar.Icon/Avatar.Text,TouchableRipple(underlayColor),BottomNavigation/.Bar,SegmentedButtons,RadioButton*andCheckbox.Item.Test plan
src/components/__tests__/ColorProps.test.tsx: each updated component renders with aColorValueprop.yarn typecheck,yarn lintand the new test pass.No visual change, so no screenshots.