Repository navigation
Pass config to pytest_report_teststatus in the nbdime reporter - #234
Open
julian-belina wants to merge 1 commit into
Open
julian-belina wants to merge 1 commit into
julian-belina wants to merge 1 commit into
Conversation
pytest 9 has a built-in pytest_report_teststatus implementation (in
_pytest/subtests.py) that takes config. NbdimeReporter calls the hook
without it, so pluggy raises
HookCallError: hook call must provide argument 'config'
and a run with --nbdime ends with an internal error. This is why
test_nbdime fails with pytest 9.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NbdimeReporter.pytest_runtest_logreportcalls thepytest_report_teststatushook without itsconfigargument. pytest 9 has a built-in implementation of this hook (in_pytest/subtests.py) that takesconfig, so pluggy raises an error and a run with--nbdimestops:This is why
test_nbdimefails on AppVeyor for Python 3.10–3.12, which get pytest 9.2. Python 3.9 gets pytest 8.4 and passes. This PR passesconfig=self.config, which the hook specification has included for all pytest versions that nbval supports.With pytest 9.2 on Windows,
test_nbdimefails before this change and passes after it.🤖 Generated with Claude Code