Repository navigation
Write pnpm overrides to pnpm-workspace.yaml on pnpm 11 and later - #1109
Merged
NullVoxPopuli merged 2 commits intoNov 12, 2026
Merged
NullVoxPopuli merged 2 commits into
NullVoxPopuli merged 2 commits into
Conversation
pnpm 11 stopped reading the `pnpm` field in package.json. Scenario overrides, and the automatic `$name` overrides for prerelease and tarball versions, went to `pnpm.overrides` and had no effect. On pnpm 11 and later, the pnpm adapter now merges these overrides into the `overrides` setting of pnpm-workspace.yaml. The adapter backs up that file and restores it at cleanup. If ember-try created the file, cleanup deletes it. pnpm 10 and older keep the package.json behavior. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1109 +/- ##
==========================================
- Coverage 95.54% 95.49% -0.05%
==========================================
Files 21 21
Lines 516 555 +39
==========================================
+ Hits 493 530 +37
- Misses 23 25 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
kategengler
approved these changes
Nov 12, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On pnpm 11 and later, scenario overrides now go to
pnpm-workspace.yaml. Before this change, they had no effect.pnpm 11 stopped reading the
pnpmfield inpackage.json:ember-try writes scenario
pnpm.overridesto that field, and also the automatic$nameoverrides for prerelease and tarball versions, so pnpm ignores both. In ember-learn/ember-styleguide#564, the Ember 7 scenarios lost theirember-cli-htmlbarsoverride and failed withCannot read properties of undefined (reading 'templateCompiler').Changes:
overridessetting ofpnpm-workspace.yaml. The merge keeps the other settings and the comments. Anullvalue removes an existing override.pnpm-workspace.yamland restores it at cleanup. If ember-try created the file, cleanup deletes it.package.jsonbehavior.yaml, so that edits keep the comments in the file.Tests:
pnpm testpasses (158 tests). Five new tests cover pnpm 11 and later: a new file, a merge into an existing file, the tarball override, no file without overrides, and the pnpm 10 behavior.ember try:one ember-release.ember-cli-htmlbarswent to 7.0.1, and the scenario passed.Related: #970 (overrides in pnpm monorepos).
🤖 Generated with Claude Code