Repository navigation
Use relaxed atomics for cross-thread ThreadCache stats and limits. - #1819
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_1012591826
branch
4 times, most recently
from
November 12, 2026 23:44
c0590ec to
fd78d74
Compare
ThreadCache::GetStats, RecomputePerThreadCacheSize, and IncreaseCacheLimitLocked read and write other threads' size_, max_size_, and FreeList::length_ under threadcache_lock_ while the owning thread mutates them without holding the lock. Store those fields as std::atomic with memory_order_relaxed loads and stores to eliminate the data races. PiperOrigin-RevId: 1012591826
copybara-service
Bot
force-pushed
the
test_1012591826
branch
from
November 16, 2026 04:08
fd78d74 to
8d9e62f
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use relaxed atomics for cross-thread ThreadCache stats and limits.
ThreadCache::GetStats, RecomputePerThreadCacheSize, and
IncreaseCacheLimitLocked read and write other threads' size_, max_size_, and
FreeList::length_ under threadcache_lock_ while the owning thread mutates them
without holding the lock. Store those fields as std::atomic with
memory_order_relaxed loads and stores to eliminate the data races.