Repository navigation
Avoid quadratic duplicate-attribute check in ParseAttributes - #1105
Open
darshan-mog wants to merge 1 commit into
Open
darshan-mog wants to merge 1 commit into
darshan-mog wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XMLElement::ParseAttributes rejects repeated attributes by calling Attribute() for each new one, which walks every attribute parsed so far, so a single element with N attributes costs O(N^2) string compares inside Parse(). A 1 MB document that is one element with 100k unique attributes (
<r a0='' a1='' ...) took 14.6 s to parse here at -O2 and now takes 4.3 ms (10k attributes: 146 ms to 0.5 ms, 40k: 2.3 s to 2.0 ms). Elements with up to 16 attributes keep the existing linear check; past that the names go into an open-addressed hash set built on DynArray, so a duplicate is still reported as XML_ERROR_PARSING_ATTRIBUTE at the same attribute.