Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1046.
Add
XMLElement::QueryText(const char**)so callers can initialize a text valuewith a default and preserve it when the element has no eligible text node. The
method follows
GetText()semantics, returnsXML_SUCCESSorXML_NO_TEXT_NODE, and uses document-owned text without allocating a separatebuffer. The header documents the returned pointer's lifetime.
Tests cover ordinary and missing text, a nested element preceding text, leading
comments, CDATA, UTF-8/entity decoding, and an empty programmatic text node.
Verification on Windows with MinGW GCC/G++ 15.2.0: Debug static, Release static,
and Release shared builds and CTest runs passed;
xmltestreported 543 passedchecks and zero failures. Test configurations were run separately because they
share fixture output files.
AI assistance: ByteAsk assisted with investigation, implementation, test authoring,
and verification. Codex assisted with repository selection, review, and independent
build/test verification.