Repository navigation
fix(files_sharing): respect openfile parameter for external file shares - #65997
sundeep8967 wants to merge 2 commits into
Conversation
|
looks good, but please add a playwright regression test for this. |
228053b to
436a30b
Compare
|
Added the Playwright regression test under |
When navigating to an external single-file share with `openfile=false`, the public router initialization previously hardcoded `openfile: 'true'` in goToRoute(), causing the file viewer to open automatically even when explicitly requested not to autoplay or open. Check the current query parameter and preserve 'false' when provided. Fixes nextcloud#65814 Signed-off-by: sundeep8967 <sundeep8967@gmail.com>
436a30b to
66eb628
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
@susnux any feedback please |
Summary
When navigating to an external single-file share link with
?openfile=false,apps/files_sharing/src/init-public.tspreviously hardcodedopenfile: 'true'during router redirection. This caused the viewer to autoplay or open the file even when explicitly requested not to open it.This PR checks the current query parameter
window.OCP.Files.Router.query.openfileand preserves'false'when supplied; otherwise it defaults to'true'.Checklist
3. to review, feature component)stable32)AI (if applicable)