Repository navigation
Conversation
…l-as-pid1 # Conflicts: # cli_test.go
|
Merged the current On the earlier red run: none of the failures came from this change. The static GNU builds failed compiling a third-party Locally, in |
dunglas
left a comment
There was a problem hiding this comment.
LGTM but another careful review by a maintainer would be very welcome :)
Summary
runtime.raisebadsignalloop cannot hang the suiteThe underlying signal-forwarding problem is golang/go#59569. This keeps the workaround local to FrankenPHP and avoids carrying a patched Go toolchain.
Closes #2558.
Verification
runnertarget with Go 1.26.5 and PHP 8.4go test -race -count=1 .go test -race ./...incaddy/TestCThreadSegfaultAsPID1exits 2 instead of timing outThe focused test can be run after building the existing test helper:
If unprivileged PID namespaces are disabled, opt into the same strict fallback used by CI:
FRANKENPHP_TEST_PID_NAMESPACE_WITH_SUDO=1 go test -race -run '^TestCThreadSegfaultAsPID1$' -count=1 -v .