Skip to content

gh-158166: Make ElementTree ParseError messages strings - #158168

Merged
serhiy-storchaka merged 6 commits into
python:mainfrom
alexprengere:gh-158166-xml-parseerror-difference
Nov 12, 2026
Merged

gh-158166: Make ElementTree ParseError messages strings#158168
serhiy-storchaka merged 6 commits into
python:mainfrom
alexprengere:gh-158166-xml-parseerror-difference

Conversation

@alexprengere

@alexprengere alexprengere commented Sep 25, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

This fixes issue #158166. We now always cast ParseError first argument to a str, like what is already done in _elementtree.c.

@python-cla-bot

python-cla-bot Bot commented Sep 25, 2026 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app bedevere-app Bot mentioned this pull request Sep 25, 2026
Closed
caje731
caje731 reviewed Sep 30, 2026
View reviewed changes

@caje731 caje731 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alexprengere

alexprengere commented Oct 20, 2026

Copy link
Copy Markdown
Contributor Author

As it has been almost 1 month, following the devguide, gentle ping 😉

For the record this exact fixed has been merged and released in the latest PyPy (8.0.1), and caused an issue for rich exception rendering.

serhiy-storchaka
serhiy-storchaka reviewed Nov 11, 2026
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but could you please reword the NEWS entry?

Comment thread Misc/NEWS.d/next/Library/2026-09-26-09-44-59.gh-issue-158166.lVGCsI.rst Resolved
@serhiy-storchaka serhiy-storchaka added needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Nov 12, 2026
@serhiy-storchaka
serhiy-storchaka merged commit 9894dc7 into python:main Nov 12, 2026
64 checks passed
@miss-islington-app

miss-islington-app Bot commented Nov 12, 2026

Copy link
Copy Markdown

Thanks @alexprengere for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Nov 12, 2026

Copy link
Copy Markdown

Sorry, @alexprengere and @serhiy-storchaka, I could not cleanly backport this to 3.15 due to a conflict.

Please backport manually with cherry_picker, see the devguide for more information.

cherry_picker 9894dc7af5e1e095467b41648c0572d76280c001 3.15

@bedevere-app

bedevere-app Bot commented Nov 12, 2026

Copy link
Copy Markdown

GH-161885 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Nov 12, 2026
@bedevere-app

bedevere-app Bot commented Nov 12, 2026

Copy link
Copy Markdown

GH-161891 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Nov 12, 2026
@alexprengere

alexprengere commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

@serhiy-storchaka I tried to use cherry_picker to manage the 3.15 backport that failed, but ran into some issues (that look similar to already opened issues).
I opened the backport manually at #161891

serhiy-storchaka pushed a commit that referenced this pull request Nov 12, 2026
@miss-islington @alexprengere
[3.14] gh-158166: Make ElementTree ParseError messages strings (GH-15…
d927542 
…8168) (GH-161885)

(cherry picked from commit 9894dc7)

Co-authored-by: Alex Prengère <2138730+alexprengere@users.noreply.github.com>
serhiy-storchaka pushed a commit that referenced this pull request Nov 14, 2026
@alexprengere
[3.15] gh-158166: Make ElementTree ParseError messages strings (GH-15…
2673045 
…8168) (GH-161891)

(cherry picked from commit 9894dc7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
+1 more reviewer
@caje731 caje731 caje731 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@serhiy-storchaka serhiy-storchaka

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexprengere @caje731 @serhiy-storchaka