Repository navigation
Conversation
Member
Author
|
CC @maurycy |
pablogsal
changed the title
pablogsal
marked this pull request as ready for review
November 14, 2026 00:59
pablogsal
added
type-refactor
Contributor
- Search `dyld.uuidArray` first, then `infoArray`, then memory - Replace dyld snapshot retries and timestamp checks with candidate validation and a fallback to mapped images - Support only little-endian 64-bit Mach-O images: arm64 and x86_64, including Rosetta. - Single 4KiB read for headers and load commands - Remove duplicate `PyRuntime` lookups - Lazy asyncio debug initialization unless it's needed?
Use dyld UUID entries for runtime discovery and defer asyncio offset lookup.
Check the known runtime address when optional image lookup fails, and preserve fatal exceptions through async discovery.
Member
Author
|
@maurycy I merged your changes, thanks again! I also fixed the case where the target exits before the first async read, so it still raises |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite the platform-specific lookup code used by Tachyon. macOS now searches dyld's UUID array first, then the full image list, then executable memory regions. It reads 64-bit Mach-O headers from target memory, with a 4 KiB initial read and a fallback for larger load commands. Native thread IDs replace the inferred pthread offset and cache for CPU state.
Windows now queries each target thread through
NtQueryInformationThread. This removes the system-wide process snapshot and its buffer. The query checks the returned process and thread IDs and closes the handle after each call. Native thread IDs remain unsigned throughout the lookup.Runtime initialization no longer repeats the
PyRuntimelookup. Asyncio offset discovery waits until the first async request. If the target exits before that request, the profiler raisesProcessLookupErrorinstead of an asyncio-unavailable error.Related to #138122 (PEP 799) and #135953 (the original profiler proposal).