Repository navigation
[pyserial] Correct optional timeout and threaded write types - #16798
Open
iamabhisheknag wants to merge 3 commits into
Open
iamabhisheknag wants to merge 3 commits into
iamabhisheknag wants to merge 3 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
srittau
reviewed
Nov 14, 2026
| def __init__(self, serial_instance: Serial, protocol_factory: Callable[[], _P]) -> None: ... | ||
| def stop(self) -> None: ... | ||
| def write(self, data: ReadableBuffer) -> int: ... | ||
| def write(self, data: ReadableBuffer) -> int | None: ... |
Collaborator
There was a problem hiding this comment.
While this calls Serial.write and the three variants are annotated as returning int | None, I don't think that's true? When tracing the code it seems to always return int (or throw) for all three variants.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Match the blocking timeout contract and threaded write forwarding: allow
Nonetimeout values/results and preserve optional write results from serial implementations.AI assistance: OpenAI coding assistant (GPT-6).