Repository navigation
[visual testing] open-example: Wait for RNTester before linking, and retry until the example opens - #60004
Open
robhogan wants to merge 1 commit into
Open
[visual testing] open-example: Wait for RNTester before linking, and retry until the example opens#60004robhogan wants to merge 1 commit into
robhogan wants to merge 1 commit into
Conversation
robhogan
force-pushed
the
robhogan/visual-ios-accept-link
branch
from
November 14, 2026 08:22
f81f277 to
7f32263
Compare
RNTester ignores a deep link until its JS has rendered, but `open-example.yml` only waited for animations to end, which happens about 1.4s after relaunch, before RNTester takes links (about 2.7s). Since #59994 sent the link once on iOS, 17 of 25 iOS capture jobs had a flow fail its first attempt this way. The helper now waits for the "Components" tab label, which RNTester's tab bar shows on every screen, then links once. It also takes the ID of an element only that example has, and relaunches and links again until it's visible, up to 3 times, since a relaunch can restore the previous example, which has the same `example-container`. Changelog: [Internal]
robhogan
force-pushed
the
robhogan/visual-ios-accept-link
branch
from
November 14, 2026 09:23
7f32263 to
eb0d03a
Compare
huntie
approved these changes
Nov 14, 2026
robhogan
enabled auto-merge (squash)
November 14, 2026 12:00
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RNTester ignores a deep link until its JS has rendered, but
open-example.ymlonly waits for animations to end - which on a fresh iOS simulator happens ~1.4s after relaunch, before RNTester takes links at ~2.7s. Since #59994 sent the link once on iOS, 17 of 25 iOS capture jobs had a flow fail its first attempt this way (29 failures across almost every flow), and in one job the retries ran out.This waits for the "Components" label in RNTester's tab bar, which is on every screen including a restored example, before linking once. That wait is optional, and as a backstop the helper now takes the ID of an element only the requested example has, then relaunches and links again until it's visible, up to 3 times. The five call sites that only waited for
example-containernow use a specifictestIDfrom their example.Changelog: [Internal]
Test plan:
Ran every visual flow once (no Maestro retries) on a freshly erased iPhone 17 Pro simulator (iOS 27) with RNTester Release from CI. Locally the drop is deterministic:
main(wait for animations)retrywith the animation waitmaestro check-syntaxpasses for every flow.On CI (run 43580332516), both platforms passed all 12 flows on their first attempt, with no relaunch retries and no "Components" timeouts. The iOS capture job took 19m, against 18-27m on
mainsince #59994.