Repository navigation
Conversation
…droid Summary: In `JavaTurboModule::invokeJavaMethod`, the `NumberKind` case only handled boxed `Double`/`Float`/`Integer` and primitive `D`/`F`/`I` return types. Any other return type fell through into the `StringKind` case, which called the method as an object-returning method and converted the result as a string. Throw a `std::runtime_error` naming the method and its return type instead, matching how the `default` case reports an unknown method kind. Changelog: [Android][Fixed] - Throw an error instead of treating the result as a string when a number TurboModule method has an unexpected return type Differential Revision: D131835371
meta-cla
Bot
added
the
CLA Signed
|
@r-barnes has exported this pull request. If you are a Meta employee, you can view the originating Diff in D131835371. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
In
JavaTurboModule::invokeJavaMethod, theNumberKindcase only handled boxedDouble/Float/Integerand primitiveD/F/Ireturn types. Any other return type fell through into theStringKindcase, which called the method as an object-returning method and converted the result as a string. Throw astd::runtime_errornaming the method and its return type instead, matching how thedefaultcase reports an unknown method kind.Changelog: [Android][Fixed] - Throw an error instead of treating the result as a string when a number TurboModule method has an unexpected return type
Differential Revision: D131835371