Repository navigation
Conversation
maebeale
changed the title
maebeale
changed the title
maebeale
marked this pull request as ready for review
October 28, 2026 10:52
The thumbnails are too small to check a connected frame or signature; clicking one now shows the whole certificate with sample content, its signature, and a print/PDF button. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…fore saving Admins want to see a frame or signature on the certificate before it goes live, so the preview takes the picks as query params and only connects them on Save. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
maebeale
force-pushed
the
maebeale/awbw-certificates-preview
branch
from
November 15, 2026 03:15
7659f2a to
3909064
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bundler-audit started failing CI on every branch once these advisories landed; both are patch-level bumps. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 3 Read 📖 admin-only preview page with try-before-save pickers, reusing the certificate partials and role connect logic
Admins can click a certificate thumbnail on Resource roles to see the whole certificate. There they can try a different background or signature and save it only when it looks right.
What is the goal of this PR and why is this important?
How did you approach the change?
/admin/resource_roles/:slot/preview.frame_id/signature_idparams. Nothing is written.PATCHsame path) connects both roles in one transaction. A blank pick disconnects.Also in here
Features seed (optional)
🤖 Generated with Claude Code