Repository navigation
fix(memory): bound pet marketplace asset cache - #1189
kogekiplay wants to merge 2 commits into
Conversation
|
Could a maintainer rerun the unsuccessful jobs in this CI run? The Ubuntu desktop runner received a shutdown signal during |
The bounded cache lengthens loadAsset's promise chain, so two microtask yields no longer reach the hook's late callback and the test passed even without the cancellation guard. Resolve inside an awaited act instead.
|
Verdict: the approach holds, and with one test fix on top this is ready. The problem is real. Review findings:
Verification:
The changes were pushed to this pull request (1 file, +2/-3). 🤖 Generated with Codeg |
Browsing pet marketplace pages kept every successful poster and preview's Base64 payload in a page-wide map. Closing a card or the dialog revoked its blob URL, but the fetched bytes remained reachable for the lifetime of the WebView.
Keep up to 64 recently used assets and 16 MiB of estimated string storage. Pending requests still share one fetch per URL; oversized previews still display for current consumers and are not cached after the fetch settles. Each consumer keeps ownership of its own blob URL.
The three new regressions fail on the previous implementation and pass with the fix. The pet suites, full frontend suite on Node 24 (13,125 tests), lint, and static export passed.