Repository navigation
perf: refresh sidebar age labels without rendering the list - #1191
kogekiplay wants to merge 2 commits into
Conversation
|
Verdict: the approach holds, and this is ready. Before this change, a Checked:
Changed on top: one docs-only commit. Two comments in Non-blocking note: only the card unit tests use the card's Verification: prettier and eslint are clean, the full vitest suite passes (13,126 tests), and the static export build (with type checking) passes. A second, independent review found no blocking issues. The changes were pushed to this pull request (1 file, +7/-8). 🤖 Generated with Codeg |
The sidebar's minute tick currently re-renders the virtualizer even when every displayed age label stays the same. Keep the shared 60-second clock and let each visible age label subscribe to its formatted text. Updating a label no longer re-renders the list or its conversation card.
For a native check of the actual patch, one signed WKWebView test host loaded the dependency-matched control and patched frontend resources in two serial, invisible 12-minute runs. Each had four sidebar rows, 358 physical-footprint samples, and 11 observable clock firings. Native command totals and DOM element counts at both endpoints matched. From the first to the last three-minute bin, footprint Q1 rose 1.81 MiB in the control and 0.80 MiB with the patch. Tick intervals with a rise of at least 1 MiB fell from six to three; several excursions recovered on the next sample. This measures one hidden test pair and does not establish the long-term effect in visible production windows.
The sidebar regression covers both cases: a minute with unchanged labels does not re-render the list or cards, and a later tick still updates the label when its formatted age changes. Formatting, lint, all 13,126 frontend tests, and the static export build (including TypeScript) passed. All ten jobs in the PR CI run passed.