Repository navigation
Fix RSocket protocol links in PayloadExchangeType - #20116
Open
farisbasha wants to merge 1 commit into
Open
farisbasha wants to merge 1 commit into
farisbasha wants to merge 1 commit into
Conversation
The Javadoc links to https://rsocket.io/docs/Protocol, which now returns 404. The protocol specification moved to https://rsocket.io/about/protocol and its frame anchors were renamed (for example #frame-fnf is now #request_fnf-fire-n-forget-frame-0x05). Point each constant at the matching frame section. Signed-off-by: farisbasha <farisbashatm@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Javadoc of
PayloadExchangeTypelinks every constant to a frame section ofhttps://rsocket.io/docs/Protocol, which now returns 404. The RSocket protocol specification moved tohttps://rsocket.io/about/protocol, and the section anchors changed too:SETUP#setup-frame-0x01#setup-frame-0x01FIRE_AND_FORGET#frame-fnf#request_fnf-fire-n-forget-frame-0x05REQUEST_RESPONSE#frame-request-response#request_response-frame-0x04REQUEST_STREAM#request-stream-frame#request_stream-frame-0x06REQUEST_CHANNEL#request-channel-frame#request_channel-frame-0x07PAYLOAD#payload-frame#payload-frame-0x0aMETADATA_PUSH#frame-metadata-push#metadata_push-frame-0x0cI checked that the new page returns 200 and that each anchor exists on it (
id="..."in the page HTML). Javadoc-only change; the three lines that got longer are wrapped in the same<a href=style used elsewhere in the codebase to stay within the formatter's line width.Prepared with AI assistance (Claude Code).