Skip to content

Fix RSocket protocol links in PayloadExchangeType - #20116

Open
farisbasha wants to merge 1 commit into
spring-projects:mainfrom
farisbasha:fix-rsocket-protocol-links
Open

farisbasha wants to merge 1 commit into
spring-projects:mainfrom
farisbasha:fix-rsocket-protocol-links

Conversation

@farisbasha

Copy link
Copy Markdown

The Javadoc of PayloadExchangeType links every constant to a frame section of https://rsocket.io/docs/Protocol, which now returns 404. The RSocket protocol specification moved to https://rsocket.io/about/protocol, and the section anchors changed too:

Constant Old anchor New anchor
SETUP #setup-frame-0x01 #setup-frame-0x01
FIRE_AND_FORGET #frame-fnf #request_fnf-fire-n-forget-frame-0x05
REQUEST_RESPONSE #frame-request-response #request_response-frame-0x04
REQUEST_STREAM #request-stream-frame #request_stream-frame-0x06
REQUEST_CHANNEL #request-channel-frame #request_channel-frame-0x07
PAYLOAD #payload-frame #payload-frame-0x0a
METADATA_PUSH #frame-metadata-push #metadata_push-frame-0x0c

I checked that the new page returns 200 and that each anchor exists on it (id="..." in the page HTML). Javadoc-only change; the three lines that got longer are wrapped in the same <a href= style used elsewhere in the codebase to stay within the formatter's line width.

Prepared with AI assistance (Claude Code).

The Javadoc links to https://rsocket.io/docs/Protocol, which now
returns 404. The protocol specification moved to
https://rsocket.io/about/protocol and its frame anchors were renamed
(for example #frame-fnf is now #request_fnf-fire-n-forget-frame-0x05).
Point each constant at the matching frame section.

Signed-off-by: farisbasha <farisbashatm@gmail.com>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 17, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: waiting-for-triage An issue we've not yet triaged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants