Repository navigation
docs: use dedicated zero-dimensional tensor constructor in blas/ext/base/ndarray/zwxsa - #16686
Merged
Merged
Conversation
…base/ndarray/zwxsa`
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
4 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #16654.
Description
This pull request:
@stdlib/blas/ext/base/ndarray/zwxsato use the dedicatedComplex128Tensor0Dconstructor (@stdlib/ndarray/tensor0d/complex128) instead of@stdlib/ndarray/from-scalarwhen creating the zero-dimensionalalphandarray. The change covers the README examples, REPL text, TypeScript declaration example and type tests (docs/types/test.ts), JSDoc examples (lib/index.js,lib/main.js,lib/native.js),examples/index.js, the benchmarks, and the unit tests.Runtime code and TypeScript signatures are unchanged. The only edits under
lib/are@examplecomments.Related Issues
This pull request has the following related issues:
Reference Packages
This pull request followed these packages:
blas/ext/base/ndarray/daxpby(commit 3757981, referenced in the issue)blas/ext/base/ndarray/caxpby(for theComplex64Tensor0Dpattern)blas/ext/base/ndarray/cxsa(docs: use dedicated zero-dimensional tensor constructor inblas/ext/base/ndarray/cxsa#16685, the complex64 counterpart of this change)blas/ext/base/ndarray/cunitspace(docs: use dedicated zero-dimensional tensor constructor inblas/ext/base/ndarray/cunitspace#16675, including the review feedback)from-scalarplus the{ 'dtype': ... }options object with the typedtensor0dconstructor.complex128takes the real and imaginary parts directly (new Complex128Tensor0D( 5.0, 0.0 )), so the intermediateComplex128instance and itsrequirewere removed.cxsa, the examples in this package also create an output vectorw, so the blank line that was removed sits betweenwandalpha.examples/index.js, because other statements sit between the declarations there.alphawith a zero value (new Complex128( 0.0, 0.0 )); these becamenew Complex128Tensor0D( 0.0, 0.0 ).Questions
No.
Other
Run locally for this package:
examples/index.jstest/test.js(4/4 pass),test/test.main.js(21/21 pass)benchmark/benchmark.js(18/18 pass)make lint-javascript-fileson the changed JavaScript files (no issues)make lint-markdown-fileson the README (no issues)make lint-typescript-declarations-filesondocs/types/index.d.tsanddocs/types/test.ts(no issues)@stdlib/_tools/lint/repl-txt) on the package'sdocs/repl.txt(no errors or warnings)test/test.native.jsandbenchmark/benchmark.native.jswere updated in the same way but not executed, because building this package's native addon requiresgfortran, which is not available in my environment.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
N/A. No AI assistance was used.
@stdlib-js/reviewers