Skip to content

test: use dedicated zero-dimensional tensor constructor in ndarray/fliplr - #16692

Merged
kgryte merged 1 commit into
stdlib-js:developfrom
devnaldo:docs-tensor0d-ndarray-fliplr
Nov 18, 2026
Merged

kgryte merged 1 commit into
stdlib-js:developfrom
devnaldo:docs-tensor0d-ndarray-fliplr

Conversation

@devnaldo

Copy link
Copy Markdown
Contributor

Resolves a part of #16654.

Description

What is the purpose of this pull request?

This pull request:

  • updates the tests of @stdlib/ndarray/fliplr to use the dedicated Float64Tensor0D constructor instead of @stdlib/ndarray/from-scalar when creating a zero-dimensional float64 ndarray. The runtime implementation and TypeScript declarations are unchanged.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Reference Packages

Did the content of this pull request follow one or more existing packages? Answering is optional.

This pull request followed these packages:

  • blas/base/ndarray/daxpy

What carried over from the reference(s)?

  • Replaced @stdlib/ndarray/from-scalar with @stdlib/ndarray/tensor0d/float64 and used new Float64Tensor0D( value ), preserving the existing value and behavior.

What differed, or what did you have to work out yourself?

  • The previous call also passed 'order': 'row-major'. I dropped it because that is the constructor's default and the test does not assert on array order.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure


@stdlib-js/reviewers

…liplr`

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@devnaldo
devnaldo requested a review from a team November 18, 2026 09:04
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Nov 18, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
ndarray/fliplr $\\color{green}110/110$
$\\color{green}+100.00\\%$
$\\color{green}5/5$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}110/110$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added Documentation Improvements, additions, or changes to documentation. difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 5 and removed Needs Review A pull request which needs code review. labels Nov 18, 2026
@kgryte kgryte changed the title docs: use dedicated zero-dimensional tensor constructor in ndarray/fliplr test: use dedicated zero-dimensional tensor constructor in ndarray/fliplr Nov 18, 2026
@kgryte
kgryte merged commit 1664e13 into stdlib-js:develop Nov 18, 2026
97 checks passed
@kgryte kgryte added Tests Pull requests specifically adding tests. and removed Documentation Improvements, additions, or changes to documentation. labels Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Good First PR A pull request resolving a Good First Issue. review: 5 Tests Pull requests specifically adding tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants