Skip to content

docs: fix format specifier in examples - #16693

Merged
kgryte merged 1 commit into
developfrom
philipp/fix-commit-review-2026-11-18
Nov 18, 2026
Merged

kgryte merged 1 commit into
developfrom
philipp/fix-commit-review-2026-11-18

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

Follow-up fixes for commits merged to develop between 2026-11-17T21:38:09Z and 2026-11-18T10:46:29Z (ce75341b1^..82c1c752f).

This pull request:

  • blas/ext/base/gwxsadb: use %0.4f for the result in the logEach format string in examples/index.js and README.md (introduced in a19f991). w = (x-3)/2 yields half-integer values, and %d truncates them (e.g., (4 - 3) / 2 = 0). Matches gwxdy and grescale.

Related Issues

Does this pull request have any related issues?

None.

Reference Packages

Did the content of this pull request follow one or more existing packages? Answering is optional.

This pull request followed these packages:

  • blas/ext/base/gwxdy
  • blas/ext/base/grescale

What carried over from the reference(s)?

  • %0.4f format specifier for floating-point results in example output.

What differed, or what did you have to work out yourself?

  • Nothing.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation. All 30 first-parent commits in the window were reviewed by two style-compliance passes (against docs/style-guides and sibling reference packages) and two bug-scan passes. Only objective bugs, unambiguous style-guide violations, and on-sight typos were kept. Each surviving finding was re-verified against the diff. Anything requiring interpretation, or changes outside the diff window, was excluded.

Escalation (not fixed here). 83652c1 changed utils/json-pointer/resolve to return undefined for nonexistent locations, but utils/json-pointer/get and utils/json-pointer/has still dereference the result. has( { 'a': 1 }, '/b' ) now throws TypeError instead of returning false, and get( { 'a': 1 }, '/b' ) throws TypeError instead of the documented Error/RangeError. The fix touches packages outside the diff window and depends on whether get should throw or return undefined, so it is left for a maintainer.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was written primarily by Claude Code as part of an automated daily review of commits merged to develop; it remains a draft pending maintainer audit.



Generated by Claude Code

…xamples

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017wWD783dvsa7CCCcKoxynk
@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Nov 18, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/gwxsadb $\\color{green}169/169$
$\\color{green}+100.00\\%$
$\\color{green}5/5$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}169/169$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added the Documentation Improvements, additions, or changes to documentation. label Nov 18, 2026
@kgryte
kgryte marked this pull request as ready for review November 18, 2026 18:34
@kgryte
kgryte requested a review from a team November 18, 2026 18:34
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. labels Nov 18, 2026
@kgryte kgryte changed the title fix: use floating-point format specifier in blas/ext/base/gwxsadb examples docs: fix format specifier in examples Nov 18, 2026
@kgryte
kgryte merged commit da842eb into develop Nov 18, 2026
84 checks passed
@kgryte
kgryte deleted the philipp/fix-commit-review-2026-11-18 branch November 18, 2026 18:35
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Documentation Improvements, additions, or changes to documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants