Repository navigation
Conversation
Pass the SAML dedicated_scope option when creating an SSO provider and surface saml.dedicated_scope in provider output. The field is create-only, so sso update does not accept it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🤖 AI Review
Verified all four Claude findings against the checked-out code; Codex reported no findings. Confirmed the dedicated-provider URL discoverability gap, incomplete documentation, missing dedicated-scope integration cases, and stale comment. No additional issues found. Tests were not run.
Findings
| Severity | Location | Category | Sources | Claim |
|---|---|---|---|---|
| 🟡 MINOR | apps/cli/src/commands/sso/add/add.command.ts:57 |
ux |
claude | The CLI can create dedicated-scope providers but does not expose their SP entity ID or ACS URL. sso info still presents only shared project-wide URLs without warning that dedicated providers require different URLs, and provider tables omit the dedicated-scope setting. |
| 🟡 MINOR | apps/cli/src/commands/sso/add/add.integration.test.ts:1129 |
test-coverage |
claude | Dedicated-scope integration tests cover only a bare flag and an absent flag; they do not verify explicit false forwarding, invalid-value rejection before requests, or repeated-flag precedence. |
| 🟡 MINOR | apps/cli/src/commands/sso/add/SIDE_EFFECTS.md:57 |
documentation |
claude | The SsoInvalidFlagValueError exit-code row omits --dedicated-scope, and the consent-prompt documentation omits the new Dedicated scope detail. |
| ⚪ NIT | apps/cli/src/commands/sso/add/add.handler.ts:132 |
documentation |
claude | The scanner comment incorrectly states that --skip-url-validation is the command's only boolean flag. |
Findings outside the diff
- 🟡 MINOR
apps/cli/src/commands/sso/add/SIDE_EFFECTS.md:57— The SsoInvalidFlagValueError exit-code row omits --dedicated-scope, and the consent-prompt documentation omits the new Dedicated scope detail. - ⚪ NIT
apps/cli/src/commands/sso/add/add.handler.ts:132— The scanner comment incorrectly states that --skip-url-validation is the command's only boolean flag.
Stats
Claude findings: 4 · Codex findings: 0 · Confirmed: 4 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
CLI benchmark (Lightweight Commands): no changes foundCommit
API calls: unchanged for all 9 commands. Binary size: 135.2 MB, up 4.0 KB from 135.2 MB. Details: timing ranges, API calls per command, slowest phasesTiming ranges
API calls per command
Slowest phasesNo command moved beyond noise, so there are no phase deltas. Comment |
sso show, add and remove print the provider's own ACS URL and entity ID when its SAML scope is dedicated, and sso info accepts an optional provider ID to print those URLs. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Prashansa-K
left a comment
There was a problem hiding this comment.
Thanks for the PR.
Here are the review findings that can be blocking for this change:
sso updateoutput is inconsistent with show, add and remove. The PR addsdedicated_scopeto the Create, Get, Delete and List response overrides. It does not add one forUpdateProviderResponse_Output.sso info <provider-id>is outside this PR’s stated scope: it prints URLs for any UUID with no provider lookup (I confirmed a nonexistent ID succeeds with zero API calls), validates the UUID only after the project picker’s API call, and adds a note to the default sso info output. Add the relevant corrections here and describe the info changes in PR description. It is fine to split it into its own PR if necessary.
… changes sso update now renders the dedicated-scope rows from the provider it fetched before the update, and renderSingleProvider requires the project ref so every caller must pass it. The sso info changes move to a separate branch. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Dogfooded Merge gate: please hold this until supabase/platform#42021 is merged and deployed to staging. Staging accepts Checks that passed, at
A separate local cross-review agrees with the points already raised on |
|
@Prashansa-K This is by design, the variables / URLs follow a convention... You also get sso info if SAML is not enabled on the project. It's not a necessary precondition. |
…so-add-dedicated-scope # Conflicts: # packages/api/src/generated/openapi.json
…so-add-dedicated-scope # Conflicts: # apps/cli/src/commands/sso/add/SIDE_EFFECTS.md # apps/cli/src/commands/sso/remove/SIDE_EFFECTS.md # apps/cli/src/commands/sso/show/SIDE_EFFECTS.md
Adds a
--dedicated-scopeflag tosupabase sso add, which sets the SAMLdedicated_scopeoption so the provider gets its own entity ID, metadata URL and ACS URL.sso updatedoes not accept it.saml.dedicated_scopeis included in provider output (sso show,sso list, and the json/yaml/toml formats).sso show,add,removeandupdateprint the provider's own ACS URL and entity ID in the text table when its scope is dedicated.updatetakes the scope from the provider it fetches first, since its response omits the field.sso infois unchanged.openapi-overrides.jsonuntil the published spec documents it.Related: supabase/auth#2893, supabase/platform#42021
🤖 Generated with Claude Code