Repository navigation
Conversation
There was a problem hiding this comment.
🤖 AI Review
Both independent reviews completed. Code inspection confirms one maintainability nit; no correctness or safety defects were verified. Tests were not run.
Findings
| Severity | Location | Category | Sources | Claim |
|---|---|---|---|---|
| ⚪ NIT | apps/cli/src/commands/experimental/stack/prune/prune.handler.ts:65 |
maintainability |
claude | The orphan predicate duplicates the ordinary-workspace sentinel and part of Git repository detection from the stack identity implementation, creating a small maintenance risk if identity semantics change. |
Stats
Claude findings: 1 · Codex findings: 0 · Confirmed: 1 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
CLI benchmark (Lightweight Commands): no changes foundCommit
API calls: unchanged for all 9 commands. Binary size: 135.2 MB, unchanged. Details: timing ranges, API calls per command, slowest phasesTiming ranges
API calls per command
Slowest phasesNo command moved beyond noise, so there are no phase deltas. Comment |
kanadgupta
left a comment
There was a problem hiding this comment.
looks good to me but tagging @jgoux for an additional set of eyes to confirm that this is indeed what the expected behavior should be. imo, the issue is correct that stack status and stack list should behave the same way but i'm not sure that these types of stacks (i.e., stacks with a git init in the same directory) should be considered eligible for pruning 🧐
|
Thanks for digging into this! I share Kanad's hesitation: I don't think these stacks should be eligible for pruning.
I think #7568 is really a discoverability problem, so the fix belongs in selection rather than cleanup:
Small note: the docs here mention I'd suggest closing this one in favor of a PR with the status/start hint and the conflict-message fix. Happy to help scope it! |
…r-orphaned-stacks-followup
git init (CLI-2980)|
makes sense 🤔, reworked it in cc65200:
|
…r-orphaned-stacks-followup
TL;DR
names a project's stacks on other branches when
stack statusfinds none orstack startcreates one, and points port conflicts at the holderwhats broken?
after
git init,stack statuscould not find the old stack althoughstack liststill showed it. starting again while the old one ran hit a port conflict whose advice targeted the wrong stacknow fixed by:
when no stack matches,
stack statussuggests--stack <short id>for this project's stacks with the same name on other branches, andstack startprints the same list before it creates a stack. port conflicts now saysupabase stack stop --stack <id>for the holder. existing users see the extra start line only when such stacks existref: