Repository navigation
chore(repo): sync develop into next - #7729
Conversation
Removes the per-command `SIDE_EFFECTS.md` files and `apps/cli/src/SIDE_EFFECTS_TEMPLATE.md`. They duplicated what the handlers, tests and user docs already state, and they drifted out of date. - Rationale that existed only in those files now lives next to the code as short comments, or in the existing guides (`apps/cli/docs/compute-commands.md`, `stack-commands.md`, `command-target.md`). - `apps/cli/AGENTS.md` names tests, the error-tag fixture, the telemetry event catalog and shipped behavior as the source of truth. - The automated review prompts judge breaking changes against what the stable release ships and what the tests at the merge base assert, instead of the old `SIDE_EFFECTS.md`. - ADRs are left unchanged as historical records.
# Conflicts: # apps/cli/src/commands/functions/deploy/SIDE_EFFECTS.md # apps/cli/src/commands/functions/serve/SIDE_EFFECTS.md # apps/cli/src/commands/start/SIDE_EFFECTS.md
Claude resolved the merge of
|
There was a problem hiding this comment.
🤖 AI Review
CLI reference prose guidance: snapshot supabase/supabase@0fdee0e supplied to reviewers (advisory, not a style pass).
Both independent reviews completed with zero findings. The sync resolves three modify/delete conflicts by removing the side-effect inventories for functions deploy, functions serve, and start. The merged checkout contains no references to those three files, and the resolution changes no command behavior or CLI reference prose.
Findings
No issues found.
Stats
Claude findings: 0 · Codex findings: 0 · Confirmed: 0 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.2-sol · Trigger: manual · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
supabase-oss
left a comment
There was a problem hiding this comment.
CI is green and the AI review raised nothing the merge introduced, so this approves Claude's resolution of the sync (https://github.com/supabase/cli/actions/runs/44619551169).
Merging
developintonextconflicts. This branch starts at the tip ofdevelop(1c49238);nextis atccfe735.Conflicting files:
apps/cli/src/commands/functions/deploy/SIDE_EFFECTS.mdapps/cli/src/commands/functions/serve/SIDE_EFFECTS.mdapps/cli/src/commands/start/SIDE_EFFECTS.mdTo resolve:
git fetch origin git switch sync/develop-into-next git merge origin/next # resolve the conflicts, then commit git push origin sync/develop-into-nextApprove to fast-forward
next; do not use the merge button.