Repository navigation
Conversation
Prefix and postfix operators declared in a type are now extracted as static Java methods, named like binary operators: `prefix func -` is `minus(value)` and `postfix func ++` is `plusPlus(value)`. - JNI thunks call them without whitespace between operator and operand, `(-(x))` and `((x)++)`. With whitespace, Swift parses neither as a prefix or postfix operator. - `JavaIdentifierFactory` grouped operators by their Swift name but looked up conflicts by their Java name, so it never found operator conflicts. A prefix and a postfix form of one operator (`prefix func ...` and `postfix func ...`) now get a `Prefix` or `Postfix` suffix. - `JavaExtractDecider` skips only operators declared at file scope. Requires swift-binding-generator-core to classify operators by their `prefix` and `postfix` modifiers, rather than by the token kind of the name, which depends on whitespace.
Operators declared at file scope are now extracted as static methods on the module's Java class, named like operators declared in a type: `func * (left: Int64, right: OperatorScore)` is `MySwiftLibrary.times(2, score, arena)`. Requires swift-binding-generator-core to classify file-scope operator funcs as operators.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of skipping them like #950 proposed, let's handle them properly.
Depends on swiftlang/swift-binding-generator-core#7