Repository navigation
Skip packing custom actions in design-time builds - #738
Open
Jonathan727 wants to merge 2 commits into
Open
Jonathan727 wants to merge 2 commits into
Jonathan727 wants to merge 2 commits into
Conversation
IDE design-time builds (such as Visual Studio or ReSharper loading a project) run Compile, which runs PackCustomAction from AfterCompile. When the custom action package is out of date, for example after a Content file is edited, the design-time build runs MakeSfxCA and rewrites the .CA.dll in obj\ even though SkipCompilerExecution=true, which collides with a concurrent real build. This test demonstrates the existing behavior and fails until it is fixed.
Like the compiler, PackCustomAction now honors SkipCompilerExecution so IDE design-time builds (such as Visual Studio or ReSharper loading a project) no longer run MakeSfxCA. Previously, when the custom action package was out of date, those builds rewrote the .CA.dll in obj\ at the same time as the real build. Fixes 9260
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
wixbot
added a commit
to wixtoolset/.github
that referenced
this pull request
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes wixtoolset/issues#9260
Problem
IDE design-time builds, such as Visual Studio or ReSharper loading a project, run
Compile. That runsPackCustomActionfromAfterCompile. When the custom action package is out of date, for example after aContentfile is edited, the design-time build runsWixToolset.Dtf.MakeSfxCA.exe. This slows down normal development and rewrites the.CA.dllinobj\while a real build may be using it.Fix
PackCustomActionnow honorsSkipCompilerExecution, the same property that makes the compiler skip its work in a design-time build.Testing
The first commit adds
CanSkipPackingCustomActionInDesignTimeBuildAfterBuild, and the second commit makes it pass. It runs under the .NET SDK, MSBuild and MSBuild64. The test:Feedback and Related Issue
Let me know what you think about these changes. If you want me to squash them into a single commit, I can. Also please consider assigning wixtoolset/issues#9359 to me.