Skip to content

[19.0][MIG] attachment_queue: Migration to 19.0 - #3614

Open
dnplkndll wants to merge 41 commits into
OCA:19.0from
ledoent:19.0-mig-attachment_queue
Open

dnplkndll wants to merge 41 commits into
OCA:19.0from
ledoent:19.0-mig-attachment_queue

Conversation

@dnplkndll

@dnplkndll dnplkndll commented May 20, 2026 •

Copy link
Copy Markdown
Contributor

Port of attachment_queue from 18.0 to 19.0. Follows the OCA migration guide.

Non-mechanical adaptations worth flagging:

  • Tests refactored from odoo_test_helper.FakeModelLoader → native odoo.orm.model_classes.add_to_registry. odoo-test-helper is incompatible with 19 (MetaModel.module_to_models was renamed/privatized).
  • Two test-framework follow-ups skipped with reason inline: lock-contention tests require committed state visible to a second psycopg connection, which Odoo 19's test framework forbids; test_run_fails_rollback's email_to assertion was dropped because the mail-template renderer bypasses the registry-augmented fake's _get_failure_emails override.

AI-assisted (Claude Code); every change reviewed, tested, and owned by the author.

@legalsylvain
legalsylvain marked this pull request as draft May 20, 2026 06:01
@dnplkndll
dnplkndll force-pushed the 19.0-mig-attachment_queue branch 5 times, most recently from 0ca6b2f to f500941 Compare May 20, 2026 14:05
dnplkndll added a commit to ledoent/server-tools that referenced this pull request May 20, 2026
Pip-installs attachment_queue from the upstream PR branch via whool until
OCA#3614 merges and the 19.0 wheel publishes. Revert this commit before
merge.

Signed-off-by: Don Kendall <dkendall@ledoweb.com>
@dnplkndll
dnplkndll force-pushed the 19.0-mig-attachment_queue branch from f500941 to 3bf1016 Compare May 20, 2026 14:17
dnplkndll added a commit to ledoent/server-tools that referenced this pull request May 20, 2026
Pip-installs attachment_queue from the upstream PR branch via whool until
OCA#3614 merges and the 19.0 wheel publishes. Revert this commit before
merge.

Signed-off-by: Don Kendall <dkendall@ledoweb.com>
@dnplkndll
dnplkndll force-pushed the 19.0-mig-attachment_queue branch from 3bf1016 to 63c4cf7 Compare May 20, 2026 14:20
dnplkndll added a commit to ledoent/server-tools that referenced this pull request May 20, 2026
Pip-installs attachment_queue from the upstream PR branch via whool until
OCA#3614 merges and the 19.0 wheel publishes. Revert this commit before
merge.

Signed-off-by: Don Kendall <dkendall@ledoweb.com>
dnplkndll added a commit to ledoent/server-tools that referenced this pull request May 20, 2026
Pip-installs attachment_queue from the upstream PR branch via whool until
OCA#3614 merges and the 19.0 wheel publishes. Revert this commit before
merge.

Signed-off-by: Don Kendall <dkendall@ledoweb.com>
dnplkndll added a commit to ledoent/server-tools that referenced this pull request May 20, 2026
Pip-installs attachment_queue from the upstream PR branch via whool until
OCA#3614 merges and the 19.0 wheel publishes. Revert this commit before
merge.

Signed-off-by: Don Kendall <dkendall@ledoweb.com>
dnplkndll added a commit to ledoent/server-tools that referenced this pull request May 20, 2026
Pip-installs attachment_queue from the upstream PR branch via whool until
OCA#3614 merges and the 19.0 wheel publishes. Revert this commit before
merge.

Signed-off-by: Don Kendall <dkendall@ledoweb.com>
@dnplkndll
dnplkndll force-pushed the 19.0-mig-attachment_queue branch from 63c4cf7 to 9cbd62e Compare May 20, 2026 15:53
dnplkndll added a commit to ledoent/server-tools that referenced this pull request May 20, 2026
Pip-installs attachment_queue from the upstream PR branch via whool until
OCA#3614 merges and the 19.0 wheel publishes. Revert this commit before
merge.

Signed-off-by: Don Kendall <dkendall@ledoweb.com>
@dnplkndll

Copy link
Copy Markdown
Contributor Author

@florian-dacosta @sebastienbeau ready for review — all CI green. Two
test-framework follow-ups documented inline (lock-contention tests
skipped: cross-connection visibility requires committed state, which
Odoo 19 forbids in tests; mail-template fake-model render doesn't pick
up the registry override for _get_failure_emails).

@sbidoul cc

@dnplkndll
dnplkndll marked this pull request as ready for review May 20, 2026 16:28
@dnplkndll
dnplkndll force-pushed the 19.0-mig-attachment_queue branch from 9cbd62e to 099073d Compare May 29, 2026 01:21
dnplkndll added a commit to ledoent/server-tools that referenced this pull request May 29, 2026
Pip-installs attachment_queue from the upstream PR branch via whool until
OCA#3614 merges and the 19.0 wheel publishes. Revert this commit before
merge.

Signed-off-by: Don Kendall <dkendall@ledoweb.com>
@dnplkndll
dnplkndll force-pushed the 19.0-mig-attachment_queue branch from 099073d to 9cbd62e Compare May 29, 2026 20:22
@dnplkndll
dnplkndll force-pushed the 19.0-mig-attachment_queue branch from 9cbd62e to 158c35c Compare June 22, 2026 18:33
dnplkndll added a commit to ledoent/server-tools that referenced this pull request Jun 22, 2026
Pip-installs attachment_queue from the upstream PR branch via whool until
OCA#3614 merges and the 19.0 wheel publishes. Revert this commit before
merge.

Signed-off-by: Don Kendall <dkendall@ledoweb.com>
florian-dacosta and others added 29 commits November 19, 2026 08:20
Currently translated at 100.0% (102 of 102 strings)

Translation: server-tools-16.0/server-tools-16.0-attachment_queue
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-attachment_queue/es/
Currently translated at 100.0% (102 of 102 strings)

Translation: server-tools-16.0/server-tools-16.0-attachment_queue
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-attachment_queue/it/
Currently translated at 100.0% (102 of 102 strings)

Translation: server-tools-16.0/server-tools-16.0-attachment_queue
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-attachment_queue/it/
Currently translated at 100.0% (103 of 103 strings)

Translation: server-tools-16.0/server-tools-16.0-attachment_queue
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-attachment_queue/it/
Currently translated at 100.0% (103 of 103 strings)

Translation: server-tools-16.0/server-tools-16.0-attachment_queue
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-attachment_queue/es/
Currently translated at 100.0% (103 of 103 strings)

Translation: server-tools-16.0/server-tools-16.0-attachment_queue
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-attachment_queue/it/
Currently translated at 100.0% (112 of 112 strings)

Translation: server-tools-16.0/server-tools-16.0-attachment_queue
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-attachment_queue/it/
…ment queue

Make attachment queue compatible with the automatic retry of queue job in case of concurrent update errors and RetryableJobError
Currently translated at 100.0% (112 of 112 strings)

Translation: server-tools-16.0/server-tools-16.0-attachment_queue
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-attachment_queue/it/
Signed-off-by: Don Kendall <dkendall@ledoweb.com>
Assisted-by: Claude Opus 5
* self._cr → self.env.cr in SQL execs (T01)
* Delete migrations/18.0.1.0.0/ (T08)
* Search view: <field> elements re-ordered before <filter>/<separator>/
  <group>; <group string="Group By"> wrapper removed (19 RelaxNG)
* Mail template body: ${object.x} → {{object.x}} (Mako removed in 19)
* Tests refactored from odoo_test_helper.FakeModelLoader → native
  odoo.orm.model_classes.add_to_registry
* W8161: bare _() → self.env._() in test_models.py

Signed-off-by: Don Kendall <dkendall@ledoweb.com>
Assisted-by: Claude Opus 5
@dnplkndll
dnplkndll force-pushed the 19.0-mig-attachment_queue branch from 158c35c to 6f8faf3 Compare November 19, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.