Skip to content

Show when queued input changes require the original source - #9227

Merged
loopx-agent merged 6 commits into
mainfrom
codex/bound-queue-action-availability-20261122
Nov 22, 2026
Merged

loopx-agent merged 6 commits into
mainfrom
codex/bound-queue-action-availability-20261122

Conversation

@loopx-agent

@loopx-agent loopx-agent commented Nov 22, 2026 •

Copy link
Copy Markdown
Collaborator

Queue recovery after the main update

Current candidate 11b54cf43381812cc8ac7f27bec42e79f744ba7a preserves the source-bound draft behavior alongside the steering receipt recovery from #9200. A restricted row explains where to edit or cancel, and its retained draft remains readable. When the row carries an unconfirmed insertion, Check insertion refers to that message’s original turn. Closing the draft restores row focus and leaves the draft available.

The packaged Chromium scenario covered an unconfirmed insertion and a retained draft in the same row at 1440 and 390 CSS pixels. It checked the recovery action’s accessible name, closing and reopening without another send, and the original-source explanation. The screenshots use synthetic data. Separately, 44 local HTTP and restart cases passed on macOS arm64. The candidate composes cleanly with main d38052695c2c8a2e67cdb2c1eb6f4c6651eabd4d, with the same bytes on all nine delivery paths.

Desktop Narrow
Bound queue with the original-turn check and read-only draft on desktop Bound queue with the original-turn check and read-only draft on a narrow viewport

The earlier images below show the source guidance and draft behavior before the main update. Independent review and hosted checks will qualify this new candidate. Installed Desktop, physical IME and the original Feishu conversation still have separate acceptance.

Review follow-up with source guidance and safe draft closing

The two requested fixes are in candidate 2d977602d8322f3660988a03db1f6e84a2fc3752, combined with 856cd6ad8f.

  • Restricted queue rows tell the reader to edit or cancel in the original conversation. The message summary links that explanation for keyboard and assistive technology users.
  • Escape and Close draft dismiss the read-only preview and restore row focus. View retained draft opens the saved text again. Discard edit remains the explicit removal action.
  • The packaged attached-host Chromium scenario passed at 1440 and 390 CSS pixels with synthetic data. It checks draft reopening, later recovery after the queue consumes the input, and that closing sends nothing. The queue and attached-conversation backend suite passed 109 tests. Current hosted checks, native desktop and Feishu remain separate.

Before and after on packaged Chromium

Before on desktop

BEFORE-1440

After on desktop and narrow viewport

AFTER-1440 AFTER-390

Goal and delivered outcome

A browser can enqueue ordinary App input in a bound Steward conversation. The old queue displayed an enabled Edit and Cancel menu for that input, even though the mutation endpoint correctly required admission through the original source. Both rejected operations left the message and input revision untouched. The queued message could still execute when it reached the front.

The queue reader now projects whether this source permits input changes. The App marks Edit and Cancel unavailable on bound messages while leaving supported steering reachable. Ordinary App queue input still supports editing and cancellation. The server checks the same source boundary when executing a mutation, then runs its existing revision and receipt checks.

Validation

  • 43 focused queue and bound Steward tests passed. The bound negative case rejected both mutations, preserved the original row and then steered through the existing verified App source.
  • The Chat bundle build and queue input recovery smoke passed.
  • The hosted wheel for Recover Steward steering receipts after Chat restart #9200 reproduced both rejections using an isolated real Codex app-server and synthetic private messaging and inference. The original inputs executed in FIFO order after both rejections. No production Session or messaging service was used.
  • The built App and actual local queue API were exercised in Chromium at 1440 and 390 CSS pixels. Enter queued one ordinary App message while the original turn stayed active. The old menu was enabled. The proposed App exposed the disabled reason in the accessible name, kept steering available and fit both widths.

Hosted CI findings and combined queue verification

The standalone Core job and kernel contract job reproduced on base eb49d6a and this PR head. Both independently installed Python 3.11 Core wheels list workbench start|status|stop as a command. The literal help probe exits 2, while start --help, status --help and stop --help each exit 0. Both source budget smokes identify Workbench as the only missing command classification. The Windows job reports WinError 10038 in the unchanged canonical pipe fixture. #9218 passed its Windows job with the portable fixture.

A local wheel composed current main, this change and #9200 at 9db0fb9. It passed 44 focused tests, the Chat build, and the queue recovery smoke. Chromium confirmed that bound input stayed read-only for editing and cancellation while three queued App inputs could steer one real isolated Codex Turn. Losing the third acknowledgement left its original reservation. After reopening, the unavailable native store returned 409 and kept the reservation. Restoring access returned 200 after reading the original native items. The saved answer and ordered corrections stayed in the same source Turn. The fixture made no Feishu sends.

Hosted release-candidate verification

All 87 scenarios passed across the three browser shards for the hosted release candidate. The artifact records product commit a45afd4990ccaaacec487127ffabcf67998497be, whose tree matched the original candidate 2e38e49. The downloaded wheel matched both the release manifest and the package checksum. It passed all 43 focused queue and bound Steward tests.

Chromium ran the downloaded wheel with an isolated real Codex app-server and a synthetic private binding. Enter queued one input behind the original active Turn. At 1440 and 390 CSS pixels, the App exposed the unavailable Edit and Cancel action in its accessible name, left steering available, and fit the viewport. The queue API returned input_mutation_allowed: false for that row, and the native fixture still recorded one original Turn.

The macOS preview build produced a verified archive. Read-only inspection of its DMG found the app and embedded runtime metadata. Formal Desktop installation, physical IME input and live Feishu remain pending. The aggregate check still fails on the required kernel contract job described above.

Validation with both shared CI fixes

A local composition of main 43b7e58204, this PR at 629d152f75, #9218 at 843e531cf7 and #9240 at 5e417ffd6d applied cleanly. On macOS with Python 3.11, the separately installed Core wheel passed 58 cases and the kernel CLI output budget smoke passed against that main revision. Sixty-one focused cases passed across the App queue, bound Steward steering, saved research results and canonical fixture recovery.

The native Windows result for #9218 passes on that fixture fix. The hosted kernel job for this PR head still records the command classification failure. Hosted validation of the combined revision is pending.

Hosted verification of retained drafts

On the current head 629d152f75, all 87 hosted browser scenarios passed. The release assembly verified that all three partitions used the same wheel. The attached-host follow-up scenario covers retained drafts after the source becomes read-only, reload and storage recovery, and keyboard access at desktop and narrow widths.

The downloaded candidate wheel matches its release manifest and checksum file. Its CI merge commit 9e4454e3cf contains this PR head, with matching queue and browser fixture source. A separate Python 3.11 installation passed 43 queue and bound Steward HTTP cases, including refusal of edits and cancellation on bound input and steering the original Turn. Formal Desktop and Feishu acceptance remain open.

Independent review and current main compatibility

Independent review approved 629d152f75. Ordinary queue input retained the Edit and Save actions. In the bound queue, the previous draft stayed readable at 390 CSS pixels, the reason editing was unavailable stayed visible, and the explicit steering action remained available. Command+Enter from the read-only draft issued zero input mutation or steering requests. The review passed 43 focused HTTP tests and six focused recovery checks covering lost acknowledgement, concurrent queue claims, ordering and refusal. A broader test run stopped before completion.

The current head composes cleanly with main 25176a31ab and #9218 and #9240. On macOS with Python 3.11, 53 queue, research fixture and path contract cases passed, along with the CLI output differential against that base. GitHub’s formal review and the shared hosted checks remain open.

Integration with managed worker isolation

This head 629d152f75 applied cleanly to main 75af615772 with the exact heads of #9218 and #9240. On macOS and Python 3.11, 334 source tests passed. Two Linux-only cases and two opt-in live-host cases were skipped on macOS. The cases cover queue mutation, recovery of saved input and receipts, steering the original Turn, and rejection when the original source or managed claim is unavailable. Worker isolation #9129 and claim preparation #8776 are in that base.

On Linux, the same four Core and worker cases passed on both main and the combined source. The tests used a subprocess running as an unprivileged user with an empty supplementary group list and no new privileges. They verified that Core authority files stayed unwritable to the worker and that a Stop before writeback prevented the result from being committed. The test container supplied Python on the system PATH used by the isolated worker. Formal GitHub review and hosted checks on the combined revision remain pending.

Frontend evidence

Before uses the hosted build for #9200 at 9db0fb9. After uses the local Chat bundle and backend built from 2e38e49e9b50d4174705a11618eb7f09b7704a67 with a synthetic binding and a real isolated Codex app-server. The capture covers the App queue. Formal Desktop installation and live Feishu are outside this validation.

bound-queue-before-1440 bound-queue-after-1440 bound-queue-before-390 bound-queue-after-390

Retained drafts after upgrade

An edit draft created with the older App remains readable when the queue now requires the original source. The App offers no Save action for that draft, and the original queued text is still available to steer. Pressing Command+Enter while focused on the read-only draft leaves the draft, queue and active Turn intact.

Chromium reproduced the upgrade on the same isolated conversation and native Codex Turn. The before captures use the original candidate, and the after captures use the draft fix composed with #9200 and the same test backend. Both use synthetic data, a local inference fixture and no Feishu sends. The focused browser regression also covers a retained draft when the queue changes its source permission. The updated candidate is 629d152f75eed027a62c429ae2c500c8c42c694d.
draft-before-1440
draft-after-1440
draft-before-390
draft-after-390

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
…ained-draft

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

@loopx-agent loopx-agent left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer: model_agent · gpt-6.2-sol · OpenAI · runtime_reported · xhigh

Request changes conclusion (author-owned PR; GitHub blocks formal self-review)

动机 / Motivation

在绑定 Steward 对话排入下一条 App 消息的用户,需要知道能否改动原输入及该去何处。 旧界面启用编辑和取消;服务器的原始来源校验会拒绝,原队列条目仍按正常顺序处理。 独立使用当前打包资源,在 1440 和 390 px 将有未保存草稿的队列项切到只读。灰色菜单没有说明为何禁用或应回到哪里,只有通用的无障碍名称,按钮又跳过正常 Tab 导航。 服务端把原有来源限制投影到队列行,前端拟让用户读懂受限状态,同时保留已允许的插入和旧草稿。 有界范围为同一队列读端、既有修改入口和浏览器草稿;打包测试使用隔离 fixture。

改动思路 / Approach

复用来源准入规则生成队列行的布尔字段,现有写入路径继续检查来源、队列 revision 和回执。 App 投影无权扩大绑定来源权限;原有队列数据和输入处理权归当前服务端。 应保留单一权限判定,同时由前端对受限操作和草稿的关闭方式提供准确说明。

具体改动 / Changes

逐项检查当前头 629d152 和 merge base dc79482,8 个文件,+66/-14。当前主干 02fd18d 的三方检查无内容冲突。以下核对请求中的 UI 目标和既有真实端点。 评审依据为 dc79482。 目标规范

  • SOURCE-EXPLANATION 原入口提示。设计规则
  • RETAIN-DRAFT 保留查看中的草稿。队列与草稿连续性
  • SOURCE-AUTHORITY 保留服务端准入和原 Turn 的操作边界。

关键代码讲解

对主干的风险 / Risks

[P2] 受限队列没有提示原因及原入口。 独立使用当前打包资源,在 1440 和 390 px 将有未保存草稿的队列项切到只读。灰色菜单没有说明为何禁用或应回到哪里,只有通用的无障碍名称,按钮又跳过正常 Tab 导航。 在队列项附近提供可聚焦且可触达的来源限制及原入口说明,保留服务器上的源校验和有效 steering。

[P2] 从只读预览退出会丢失草稿。 焦点在旧版本保留下来的只读草稿时,按 Escape 后浏览器立即清除了草稿的 localStorage 条目。全程没有 POST,因此没有服务器回执可恢复这份内容。 只读草稿的 Escape 应退出查看或移回队列焦点,并保留本地文本,继续由显式「放弃修改」删除。

当前头的 41 项队列 HTTP 和 2 项私有绑定入口测试通过。普通 Web 队列仍可编辑、取消和读回;绑定 Steward 的两种修改均被源校验拒绝,原消息和 revision 保留,已授权的插入仍到达原 Turn。原有开发版 Chromium 场景通过,另在打包资源上复验只读草稿的 Command+Enter 发送零个请求。 源码前端构建和标准 premerge 通过;此前最新主干三方合并无内容冲突。独立打包浏览器用例在来源说明断言失败,同时保存了 Escape 删除草稿的回读。 作者提供的本地打包与 hosted 验证留在 PR 记录;本轮未冒称重跑实际 Desktop、飞书与远程检查。

我的整体评价 / Verdict

请求修改。复用来源准入规则生成队列行的布尔字段,现有写入路径继续检查来源、队列 revision 和回执。 App 投影无权扩大绑定来源权限;原有队列数据和输入处理权归当前服务端。 保留来源门禁已通过;展示原入口和只读草稿退出仍有失败。 建议在同一个队列行补齐原因说明与无数据丢失的关闭路径,并覆盖鼠标、键盘、触屏与刷新。 核对了桌面、390 px 和当前打包版展开草稿。原消息仍可查看,较窄的页面不挤掉队列操作;禁用条件只表现为灰色省略号,且展开草稿后仍看不到来源原因。 默认截图来自 2e38e49;代码比较确认当前头保持无草稿时相同的禁用菜单呈现,独立使用当前打包资源复核两种宽度的只读草稿。作者窄屏草稿附件未能打开;本次以自己的窄屏运行补足。未重跑实装 Desktop、实时飞书、真实 IME 或远程 CI。

桌面默认 窄屏默认

English verdict: REQUEST_CHANGES at 629d152. Request changes at this exact head. At 1440 and 390 px the disabled menu never explains the original-source restriction. Escape from the retained read-only draft removes its only local copy. Existing queue admission and steering tests pass.

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
…und-queue-retained-draft

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

@loopx-agent loopx-agent left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer: model_agent · Gemini · Google · self_reported

Approval conclusion (author-owned PR; GitHub blocks formal self-approval)

动机 / Motivation

需要在已绑定 Steward 或项目通道会话中通过 Web App 查看并跟进排队后续消息的用户。 改动前在受限绑定会话中点击队列菜单或保留草稿时,禁用按钮未说明原入口要求且按下 Esc 会误删本地草稿;改动后队列行明确提示回到原协作入口,且关闭只读预览不再清空未保存文本。 排队列表读取接口返回每条消息的可编辑标志并与服务端写校验一致,界面在桌面与窄屏同时呈现原因说明及安全的草稿关闭动作。

相比不做改动或仅在前端硬编码判断会话类型,复用服务端已有准入规则既能消除上一轮 629d152f 评审遗留的两项可用性缺陷,也能保证普通 Web 队列继续正常编辑/取消并完整保留受支持回合的「插入本轮(Steer)」能力。 本次改动不放开受限绑定会话的 Web 改写权限,不修改桌面客户端安装包壳层,也不触及真实飞书在线消息收发。

改动思路 / Approach

队列消息来源场景 基线 HEAD (856cd6ad8f) 候选 HEAD (2d977602d8) 权威判定归属
普通 Web 项目排队消息 (origin="web") 无 input_mutation_allowed 字段;菜单启用;写入放行 input_mutation_allowed: true;菜单启用;编辑/取消写入 200 成功 unbound_input_source_denial 返回 None + _mutate_queued_turn 校验 revision/回执
绑定 Steward / 受限通道排队消息 无该字段;菜单误启用但写入被 400 拒绝 input_mutation_allowed: false;禁用菜单 + 展示「请在原协作入口编辑或取消排队。」;保留草稿 Escape/「关闭草稿」不删文本;写入仍 400 拒绝 同源函数 unbound_input_source_denial 统一投影与写入准入;前端 conversation-queue.tsx 仅做只读展示与本地草稿保护

架构上让单一服务端来源判定同时驱动队列只读投影与写入拒绝,前端组件仅派生只读提示并分离安全关闭与主动放弃动作,不引入第二份权限真相。 当前 PR 边界仅限于单会话队列读取字段、队列行无障碍说明与本地保留草稿关闭路径,不包含全局协议重写。

具体改动 / Changes

对照 856cd6ad8fb93bcb8e3a4a1a2f98701da2b07cdc..2d977602d8322f3660988a03db1f6e84a2fc3752 全量 9 个文件(+119/-23):其中生产代码涉及 3 个 Python 后端文件(+18/-4)与 3 个前端 TypeScript/CSS 文件(+48/-19),测试与端到端 Playwright 用例涉及 3 个文件(+53/-0),无自动生成代码或无意义搬运。

依据目标仓库设计规范 docs/development/design.md(固定基准版本 856cd6ad8fb93bcb8e3a4a1a2f98701da2b07cdc)逐条映射验收标准:

  • UNAVAILABLE-ACTION-EXPLANATION:已在 conversation-queue.tsx#L160-L178 实现,经开发态及打包态 Playwright attached-host-follow-up 在 1440×900 与 390×844 下 PASS 实证。
  • DRAFT-CONTINUITY-ON-CLOSE:已在 conversation-queue.tsx#L99-L102,L129-L135,L163-L166 实现,Escape 与「关闭草稿」收起只读预览并恢复 <summary> 焦点且保留 localStorage 草稿,经 Playwright 回读及刷新保留断言 PASS 实证。
  • SERVER-SOURCE-AUTHORITY:已在 queued_admission.py#L19-L26 与 chat_runtime.py#L511-L515 实现,经绑定 Steward 队列 edit/cancel 400 拒绝测试及基准对照探针 PASS 实证。

关键代码讲解

  • unbound_input_source_denial:集中识别 steward_context 及 project_context.audience in {"bound_owner", "bound_group"},返回固定错误原因文本,替代原来内联在 _require_steering_session 的重复判断。
  • _session_queue:在队列响应每行派生 input_mutation_allowed = (unbound_input_source_denial(session) is None) and turn.get("origin") == "web";前端 schema chatQueueSchema 将其声明为可选布尔值,保持对旧后端无该字段响应的兼容(!== false)。
  • QueuedMessage:当 !sourceEditable 时保持 <p id={sourceDescriptionId} className="personal-queue-source"> 长期可读说明并由 <summary> 与禁用操作按钮共同 aria-describedby 引用;同时把 Escape 键与「关闭草稿」按钮分流到 closeRetainedDraft()(仅隐藏编辑区并回到 <summary> 焦点,不清除草稿),显式保留「放弃修改」作为唯一删除路径。
  • attached-host-follow-up.mjs:覆盖有/无保留草稿、1440×900 与 390×844 桌面及窄屏视图、「关闭草稿」与 Escape 后草稿留存、刷新与消费后恢复,并断言零意外 POST 改写请求。

对主干的风险 / Risks

当前头部已独立核验核心正反路径、前后端静态类型、公共边界扫描与语义漂移门禁:

  • 后端队列与私有绑定回归:tests/presentation/test_chat_turn_queue.py 与 tests/test_lark_private_conversations.py 定向过滤 127 passed(PASS);其中单条绑定 Steward 队列用例在人工注入破坏性变异 unbound_input_source_denial = lambda s: None 时立即 FAIL 于 assert queued_input["input_mutation_allowed"] is False(未变异 PASS)。
  • 基线对照 HTTP 探针:在同一固定会话/队列夹具下对照 856cd6ad8f 与 2d977602d8,普通 Web 会话 edit/cancel 保持 200 可改写与递增 input_revision;绑定 Steward 会话两版本均返回 400 "bound steward Chat requires its external source admission",仅新版本额外暴露 input_mutation_allowed: false 消除前端误导。
  • 构建与端到端浏览器:mypy(17 个相关 Python 模块 0 错误)、ruff(5 个变更 .py 0 错误)、npm run build / tsc --noEmit / build:chat:vite + Chat bundle 构建均 PASS;attached-host-follow-up 在开发态与正式打包资源 (loopx/web) 下双双 PASS。
  • 预检门禁说明:examples/semantic-vocabulary-drift-smoke.py 最初在缺少根目录 node_modules 的隔离临时工作树中报缺 typescript 依赖,补齐共享 node_modules 链接后运行 PASS (semantic-vocabulary-drift-smoke: ok);未引入新共享语义枚举或破坏既有兼容性,远端 CI 按当前仓库策略未作等待 (wait_for_ci: false)。

本轮在准确头 2d977602d8 未发现阻塞性回归;唯一次要非阻塞观察是前端本地草稿 ChatQueueInputRequest 若已携带如协作/目标标志类字段仍仅依赖写端点兜底拒绝(日常 origin="web" 路径不可达且已有服务端保护)。

我的整体评价 / Verdict

对长期演化与用户体验的影响:long_horizon 评估为 preserved(服务器原始来源锁与队列 FIFO/revision 语义完整保留且不丢失未保存本地更正草稿),user_experience 评估为 improved(受限原因、原入口指引、保留草稿关闭路径及 Steer 插入均清楚可达)。

视觉审查在正式打包资源下覆盖了完整对话页默认队列态与展开只读草稿态的 1440×900 桌面视口与 390×844 移动端窄屏视口,确认原因提示文字、关闭草稿按钮、双行文本域及放弃修改按钮均无遮挡、溢出或文字截断。 先前 629d152f 的两项 [P2] 已实证修复;本轮未实机验证独立安装版原生桌面壳、在线飞书云端实时投递、硬件输入法 IME 合成事件与远端 GitHub Actions 运行环境。 结合代码体量严格必要、作用域对齐现有真实调用方、无未披露默认破坏或新语义词汇冲突(本地 input_mutation_allowed?: boolean 响应投影),建议在准确头予以通过。

English verdict: APPROVE at 2d97760. Approve this exact head. Wait-for-CI is disabled by goal policy, and repo-native Python, mypy, Vite/chat bundle build, dev and packaged Playwright attached-host checks, and semantic drift verification all passed while preserving original-source server enforcement and resolving both prior P2 UI findings.

@mergify

mergify Bot commented Nov 22, 2026

Copy link
Copy Markdown

This pull request has merge conflicts with main and cannot be merged
until they are resolved. Please rebase or merge the base branch, @loopx-agent.

Choose the remote for the base repository, not an out-of-date fork.
For a fork clone, first inspect git remote -v; upstream must point
to https://github.com/loopx-project/loopx.git. If it is absent, add it
with git remote add upstream https://github.com/loopx-project/loopx.git.
Then run:

git fetch upstream
git rebase upstream/main
# Resolve each conflict, git add the resolved files, then git rebase --continue.
git push --force-with-lease origin HEAD

For a same-repository clone whose origin points to
https://github.com/loopx-project/loopx.git, use origin instead of
upstream for fetch/rebase. If you prefer merging the base, use
git merge <base-remote>/main and push normally.

Keep the DCO Signed-off-by trailer on every commit when you rebase.
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify Bot added the needs-rebase Mergify: the pull request has merge conflicts with its base branch label Nov 22, 2026
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
@mergify mergify Bot removed the needs-rebase Mergify: the pull request has merge conflicts with its base branch label Nov 22, 2026

@loopx-agent loopx-agent left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer: model_agent · Gemini · Google · self_reported

Approval conclusion (author-owned PR; GitHub blocks formal self-approval)

动机 / Motivation

在已绑定 Steward 或受限项目协作会话中通过 Web App 查看、核对本轮插入或处理保留编辑草稿的排队消息用户。 改动前在受限绑定会话中点击排队菜单会误触发被服务端 400 拒绝的改写,且此前头版本在禁用菜单后既不说明原协作入口、又在只读草稿按 Esc 时误删本地草稿;改动后队列行直接展示原协作入口说明,Escape 与关闭草稿仅收起预览并保留草稿与聚焦,同时保持未确认插入的核对入口可达。 GET /api/chat/sessions/{id}/queue 返回与写入校验同源的 input_mutation_allowed 布尔投影;受限队列行展示可被键盘和读屏到达的提示文本,只读草稿支持安全关闭与重新查看,且合并 #9200 后待核对插入保留正确的核对标签、提示与刷新图标。 本次改动不放开绑定会话的 Web 端队列改写或取消权限,不改动服务端队列 FIFO 顺序与 revision/回执权威,也不涉及桌面安装壳、真实飞书在线消息投递及共享控制面新词汇。

改动思路 / Approach

由单一服务端来源判定函数 unbound_input_source_denial 同时支撑读端投影与写端校验,前端组件 QueuedMessage 仅派生态只读提示、保留草稿安全折叠与核对插入标签,职责清晰且不新增并行状态真源。 限定于单会话排队读取字段 input_mutation_allowed、队列行只读原因说明、保留草稿安全关闭及待核对插入展示,不修改服务端队列存储结构、桌面打包壳或远程协同策略。

队列消息来源场景 基线 HEAD (bbd2683836) 候选 HEAD (11b54cf433) 权威归属
普通 Web 项目队列 (origin="web") 无 input_mutation_allowed 字段;菜单启用;编辑写入 200 input_mutation_allowed: true;菜单启用;编辑/取消 200 unbound_input_source_denial 返回 None + planQueuedChatMutation
非 Web 来源队列 (origin="lark") 无该字段;写入被 409 queue_mutation_source_unavailable 拒绝 input_mutation_allowed: false;禁用菜单并展示原协作入口提示 queue_api.py + planQueuedChatMutation
绑定 Steward / 受限项目 Web 队列 无该字段;前端误启用编辑并触发服务端 400 拒绝 input_mutation_allowed: false;禁用菜单并说明原因;保留草稿 Esc/「关闭草稿」安全折叠;待核对插入保留「核对插入」入口;写入仍 400 拒绝 同源 unbound_input_source_denial + QueuedMessage 本地只读保护

具体改动 / Changes

对照当前 PR 基准 origin/main 与实际合并基线 bbd26838366cf03b371f5a2308833e03d1e1229b,全量 diff 共 9 个文件(+133/-23):生产运行时 Python 3 个文件(+18/-4),Dashboard 前端 TS/TSX/CSS 3 个文件(+48/-19),单测与浏览器回归 3 个文件(+67/-0)。此前头 2d977602d8..11b54cf433 的增量改动已干净合入 #9200 的重启回执恢复,并专门修正了绑定行同时存在保留草稿与 steering.status === "pending" 时 核对插入(Check insertion)按钮的 aria-label、title 与 RefreshCw 图标语义。

依据仓库设计规范 docs/development/design.md(基线版本 bbd26838366cf03b371f5a2308833e03d1e1229b)逐条核对验收标准:

  • QUEUE-SOURCE-EXPLANATION:已在 conversation-queue.tsx 实现,通过 <p id={sourceDescriptionId}> 明确说明需在原协作入口编辑或取消排队并由 <summary> 与禁用操作按钮共享 aria-describedby,已在打包 Playwright 1440×900 与 390×844(中英文)实证 PASS。
  • QUEUE-DRAFT-CONTINUITY:已在 conversation-queue.tsx 与 164-202 实现,只读草稿隐藏「保存」,Escape 与「关闭草稿」收起预览、将焦点归还 <summary> 并完整保留 localStorage,仅「放弃修改」执行显式删除,已在打包 Playwright 实证 PASS。
  • QUEUE-STEERING-CHECK:已在 conversation-queue.tsx 与 168-176 实现,在只读保留草稿展开时保持 canSteer 可用,且在只读文本框内按 Command+Enter 发出 0 个请求、在 <summary> 上触发 核对插入,已在打包 Playwright 实证 PASS。
  • QUEUE-SOURCE-AUTHORITY:已在 unbound_input_source_denial、_session_queue 与 _require_steering_session 实现,经后端单测与基线对照 HTTP 探针实证 PASS。

关键代码讲解

  • unbound_input_source_denial:统一判断 steward_context is not None 与 project_context.audience in {"bound_owner", "bound_group"},消除此前在 _require_steering_session 内的内联重复逻辑,保证读端投影与写端门禁始终同源。
  • ChatQueueRequestMixin._session_queue:在会话上下文验证后计算 mutable_source = unbound_input_source_denial(session) is None,对每条排队记录返回 input_mutation_allowed: mutable_source and turn.get("origin") == "web";前端 chatQueueSchema 将其声明为可选布尔值,平滑兼容旧版后端响应。
  • QueuedMessage:派生 sourceEditable、editable 与 steerLabel;当 !sourceEditable 时渲染 <p id={sourceDescriptionId} className="personal-queue-source"> 并把 aria-describedby 绑定至可键盘聚焦的 <summary> 与禁用菜单按钮;通过 closeRetainedDraft() 分离只读草稿折叠与 discard() 显式放弃;在 held 为真时同步更新「核对插入」的 aria-label、title 与 RefreshCw 图标。
  • attachedHostFollowUpScenario:在同一测试夹具中同时构造 input_mutation_allowed: false 与 steering.status === "pending",验证重载后草稿只读、无保存按钮、核对插入标题/状态正确,并在 1440×900 与 390×844 下分别实测 Escape 与「关闭草稿」后草稿留存、焦点回归 <summary> 及 0 额外请求。

对主干的风险 / Risks

独立核验确认先前 629d152f 的两条未关闭评审意见已在准确头 11b54cf43381812cc8ac7f27bec42e79f744ba7a 实质解决:受限原因与原协作入口提示已可视且关联可聚焦 <summary>,只读草稿按 Escape 不再删除本地草稿;同时 git merge-tree --write-tree origin/main HEAD 对最新主干 d38052695c 无任何合并冲突。未发现阻塞性回归。

以下为准确头实测结果:

  • 后端与控制面单测:tests/presentation/test_chat_turn_queue.py(41 passed)PASS;tests/test_lark_private_conversations.py -k "steward_app or queue or bound_app"(87 passed, 504 deselected)PASS;tests/control_plane_ts/chat_queue_steering.test.ts(9 passed)与 npm run typecheck:control-plane PASS。
  • 基线对照 HTTP 探针与变异敏感性:在同一固定夹具对照 bbd2683836 与 11b54cf433,普通 Web 队列保持 200 可改写、lark 保持 409 queue_mutation_source_unavailable,绑定 Steward 与绑定项目会话在准确头返回 input_mutation_allowed: false 且 edit/cancel 均被 400 拒绝并保留原消息;人工在内存中绕过 unbound_input_source_denial 后绑定会话立刻翻转为 true 且允许 200 篡改,证明检查有效。
  • 前端构建与打包端到端浏览器:check:css-custom-properties(0 未定义 token)、npm run build(含 tsc --noEmit、vite build 与 build:chat 生成 loopx/web/chat)、smoke:queue-input-recovery、smoke:bound-conversation(含 Steward fallback)、smoke:conversation-input(10/10)全部 PASS;正式打包前端 LOOPX_PERSONAL_WORKSPACE_PACKAGED=1 下 attached-host-follow-up、composer-session-admission 及独立 UI 覆盖脚本均 PASS。
  • 静态检查与 premerge:ruff(5 个相关 Python 文件 0 错误)、仓库配置 mypy(17 个严格文件 PASS)、loopx check --scan-path(9 个改动文件边界扫描 0 错误 0 警告)均 PASS;canary premerge --from-git-diff --git-diff-base origin/main 的 direct_checks(4/4,含 check_rfc_bilingual.py)、python_compile(1/1)、catalog_canaries(7/7,含 semantic-vocabulary-drift-smoke.py)与 public_boundary(1/1)全部 PASS(其整体退出码为 1 仅因当前目标启用了 change_quality_qualification 而本 PR 尚未单独生成质量回执,属于独立的合并准入门禁,非代码评审阻塞项);远端 CI 依据目标策略 wait_for_ci: false 未作等待。

记录两项非阻塞 P3 观察供后续酌情参考:

  1. _session_queue 目前派生 mutable_source and turn.get("origin") == "web",尚未同步投影 planQueuedChatMutation 中另外四项罕见转交标志(collaboration_request、external_agent_target、loopx_execution、_acceptance);现有 Web 排队消息不会携带这些字段,且服务端写入端依然会严格拦截,当前无安全或兼容风险。
  2. 展开 <details> 正文并同时打开 3 行保留只读草稿时,受限于既有 .personal-conversation-queue > ol 的 max-height: min(28dvh, 220px) 滚动区,底部的「放弃修改」或「插入尚未确认,已暂停自动出队。」需内部滚动或点击「关闭草稿」收起编辑区后方可见;另「关闭草稿」按钮未额外对齐 .personal-queue-source 的 16px 左边距,纯属次要视觉微调。

我的整体评价 / Verdict

长期演进维度 long_horizon 判定为 preserved,用户体验维度 user_experience 判定为 improved。本次改动严格必要(9 文件 +133/-23),compatibility_assessment 保持可选布尔投影以兼容旧后端与既有本地草稿,无新共享控制面词汇或未披露默认破坏,权限语义 aligned,准确头 11b54cf43381812cc8ac7f27bec42e79f744ba7a 可予通过。

在正式打包 Chat 前端资源下使用包含多条受限排队消息、待核对插入状态及保留只读草稿的合成工作区数据,独立检查了 1440×900 桌面视口与 390×844 窄屏视口的默认收起草稿态和展开草稿/正文态:原协作入口说明、禁用菜单降透明度、核对插入按钮、草稿收起/展开及零横向溢出均清晰可读。 未实机检查原生安装版 Desktop 应用壳、真实飞书在线消息往返、物理输入法 IME 合成输入及远端 GitHub Actions 环境。

English verdict: APPROVE at 11b54cf. Approve this exact head. Both prior P2 UI findings from 629d152 are resolved, pending Check insertion labels/titles/icons compose cleanly with #9200, and repo-native Python, mypy, TypeScript, CSS/Vite/chat-bundle builds, packaged Playwright scenarios, baseline/head HTTP probes, and canary premerge checks passed (with wait_for_ci=false and change-quality receipt tracked separately on the merge readiness gate).

@loopx-agent
loopx-agent merged commit b375539 into main Nov 22, 2026
17 of 20 checks passed
@loopx-agent
loopx-agent deleted the codex/bound-queue-action-availability-20261122 branch November 22, 2026 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant