Repository navigation
Fix Workbench command catalog and manual - #9240
Merged
Merged
Conversation
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
This was referenced Nov 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The public command catalog lists
loopx workbench start|status|stopas a single example. The existing standalone Core check runs the example through the installed parser, which rejects it with exit code 2. This fails the Package Smokeloopx-corejob on #9227 and #9235. The output-budget coverage check also finds Workbench missing from its manifest, and the checked-in manual predates the catalog entry.Change
The published examples now resolve to three commands:
Verification
dc79482c88reproduced the parser error, missing manifest classification and stale manual.5e417ffd6dpassed all 58 Package Smoke Core tests with a separately installed Python 3.11 wheel on macOS. On both the source CLI and the installed console, the three subcommand help invocations returned 0. The combined spelling returned 2, and an isolated status read returnedstopped.loopx canary premerge --from-git-diff --git-diff-base origin/mainpassed.5e417ffd6da88d2aeb63b31fda786fa8efa3618e. The reviewer reproduced the baseline failures, resolved all three command examples in the isolated Python 3.11 Core wheel, checked the invalid combined spelling and isolated stopped status, and verified generated-manual parity and the existing cold-path classification.WinError 10038in the captured research fixture before running the Windows CLI budget check. Both of those steps passed on the native Windows job for #9218.2ab0d1a42bon macOS passed the CLI output differential, seven standalone Core catalog and context cases, and 26 fixture and lease-loss recovery cases. GitHub formal review and hosted validation of the combined tree remain open.